Document rules: skip links which are not being rendered or in skipped contents #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contents It's hard for the user to interact with these links, and the author may not even intend them to be part of the document's palpable content. In at least Chromium (and likely other implementations), these are also elements where the author is trying to skip work related to selector matching etc, which makes selector_matches applying to them particularly problematic. Better to ignore them altogether. Fixes WICG#246.
| Preview: |
|
@a4sriniv ptal? |
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard for the user to interact with these links, and the author may not even intend them to be part of the document's palpable content.
In at least Chromium (and likely other implementations), these are also elements where the author is trying to skip work related to selector matching etc, which makes selector_matches applying to them particularly problematic. Better to ignore them altogether.
Fixes #246.