Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to activate Steel Path component once disabled #496

Closed
NFlieger opened this issue Jun 13, 2021 · 5 comments · Fixed by #498
Closed

unable to activate Steel Path component once disabled #496

NFlieger opened this issue Jun 13, 2021 · 5 comments · Fixed by #498
Labels
released Scope: Documentation Addresses Documentation, such as guides to getting started or the readme Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug

Comments

@NFlieger
Copy link

NFlieger commented Jun 13, 2021 •
edited by TobiTenno
Loading

Summary (short):

Once you have deactivated the component "Steel Path" in the settings, you have no chance of turning it back on.

Description:

The Steel Path component seems to be linked to other components and not have it's own panel.
If you deactivate any component, the Steel Path component will be deactivated as well. Even before confirming your new components you selected in the settings by using the OK button, the panel will be hidden and components.steelPath.display in your local storage will be set to false.
From now on there is no way to set that value to true again. If you activate it in the settings menu, the panel will not show up and still be hidden, even though it looks activated in the settings menu. Once you close the settings and open it again, it show the correct status of deactivated again.
If you delete your local storage, the panel will show up again, since the initial value seems to be true.

Right now it is only possible to see the Steel Path component, if you make no changes to the components at all.

Reproduction:

  1. Open the Settings -> Components menu
  2. Deactivate any component of your liking
  3. The indicator for that component will show it is disabled now (as expected)
  4. Steel Path will be indicated as well (not expected)
  5. Close the menu (Cancel, OK, X makes no difference)
  6. Both panel will be hidden now (not expected)

Screenshots, evidence:

https://imgur.com/2LPX14K
@NFlieger NFlieger added Scope: Documentation Addresses Documentation, such as guides to getting started or the readme Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug labels Jun 13, 2021
@TobiTenno
Copy link
Member

weird, thought I'd fixed that. I'll get on it tonight.

@TobiTenno TobiTenno mentioned this issue Jun 16, 2021
Merged
@TobiTenno
Copy link
Member

Could you try the PR over on #498 to make sure it works for you, @NFlieger?

@NFlieger
Copy link
Author

The deployed preview in #498 works. The pull request seems to fix the issue. I am looking forward for it being deployed into production.

@TobiTenno
Copy link
Member

It should already be deployed. You may need to do a hard refresh (on Chrome-based browsers: Ctrl+Shift+F5) to force it to pull some new content, but the host should handle that (hopefully!)

@wfcd-bot-boi
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Scope: Documentation Addresses Documentation, such as guides to getting started or the readme Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: steel path disabling properly WFCD/warframe-hub
3 participants
@TobiTenno @NFlieger @wfcd-bot-boi