Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "missing" pages into "curation" pages #1126

Closed
Daniel-Mietchen opened this issue May 12, 2020 · 11 comments · Fixed by #1324
Closed

Rename "missing" pages into "curation" pages #1126

Daniel-Mietchen opened this issue May 12, 2020 · 11 comments · Fixed by #1324
Assignees
Labels
missing-data data relevant to Scholia that is not accessible to it usability trying to minimize bad experiences while using Scholia

Comments

@Daniel-Mietchen
Copy link
Member

  • to clarify their purpose
  • leaving redirects
@Daniel-Mietchen Daniel-Mietchen added missing-data data relevant to Scholia that is not accessible to it usability trying to minimize bad experiences while using Scholia labels May 12, 2020
@egonw
Copy link
Collaborator

egonw commented Nov 5, 2020

@Daniel-Mietchen, is this a proposal, or already approved and the patch just needs writing?

@Daniel-Mietchen
Copy link
Member Author

At this point, it is just a proposal — we have not discussed this yet. I hope to get some feedback on this today.

@egonw
Copy link
Collaborator

egonw commented Nov 30, 2020

I like the idea.

@Daniel-Mietchen
Copy link
Member Author

My motivation here is that "/missing" is a bit too ambiguous. When demoing the site to new users, phrases like "the missing pages for organizations" are then potentially misleading.

Calling them "curation" would make their purpose clearer.

@Daniel-Mietchen Daniel-Mietchen changed the title Rename "missing" pages into "curation" pages or some such Rename "missing" pages into "curation" pages Nov 30, 2020
@Daniel-Mietchen
Copy link
Member Author

This has several components that need to be coordinated:

  1. rename the missing pages
  2. rename references to the missing pages
  3. add redirects from /missing to /curation
  4. perhaps think about some consistent formatting, such that the curation links on the profile pages show up in a predictable way/ place

@Daniel-Mietchen
Copy link
Member Author

As just discussed, we are going to treat this ticket as being about 1-3, opening a new one for 4, which is #1322.

@Daniel-Mietchen
Copy link
Member Author

As just discussed, I will work on 1 and 2, and once that is set up, @egonw will do 3.

@Daniel-Mietchen
Copy link
Member Author

@egonw I think I am through with the renaming — see https://github.com/fnielsen/scholia/tree/origin/feat/curation-pages-1126 for current state.

@Daniel-Mietchen
Copy link
Member Author

Just for the record, we now have a pull request for this at #1324 .

@carlinmack
Copy link
Collaborator

carlinmack commented Jul 9, 2021

Sorry to nitpick, but is it on purpose that the URL is only available without the final /? If so, maybe a redirect should be set

For example https://scholia.toolforge.org/topic/Q202864/curation vs https://scholia.toolforge.org/topic/Q202864/curation/

@carlinmack
Copy link
Collaborator

carlinmack commented Jul 9, 2021

It seems that this is the behaviour on most pages (like any with a Q number). This seems to be a bigger than this so have created #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-data data relevant to Scholia that is not accessible to it usability trying to minimize bad experiences while using Scholia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants