Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Icon is Broken under KDE Plasma #260

Closed
polluxau opened this issue Oct 4, 2024 · 4 comments · Fixed by #263
Closed

[BUG] Icon is Broken under KDE Plasma #260

polluxau opened this issue Oct 4, 2024 · 4 comments · Fixed by #263
Labels
bug Something isn't working

Comments

@polluxau
Copy link

polluxau commented Oct 4, 2024

Describe the bug
Icon looks extremely white or overexposed in discover and when the shortcut is created

To Reproduce
Steps to reproduce the behavior:

  1. Download protonplus on kde plasma
  2. Look at the icon that is broken

Expected behavior
Should look correct

Screenshots
image

image

Desktop (please complete the following information):

  • OS:Bazzite
  • DE: KDE Plasma 6.1.5
  • Type: Flatpak

Additional context
Add any other context about the problem here.

@polluxau polluxau added the bug Something isn't working label Oct 4, 2024
@polluxau polluxau changed the title [BUG] icon is broken under kde plasma [BUG] Icon is Broken under KDE Plasma Oct 4, 2024
@Arcitec
Copy link
Collaborator

Arcitec commented Oct 4, 2024

I see. So KDE is not able to render SVG icons correctly.

Shame on KDE.

I see that it's rendering the rounded square background and its gradient correctly. But it's only rendering a single pixel of the overlay "P+" shape, lol.

Our SVG icon is correct. You can see the proper rendering by visiting it in your web browser here:

https://github.com/Vysp3r/ProtonPlus/blob/main/data/logo/com.vysp3r.ProtonPlus.svg

So it's entirely KDE's fault. Which means we will have to generate bitmap PNG icons for KDE users then. But Vysp3r is gonna be gone for over a month, and I can't create releases without him, so it will have to wait. We will take care of it later. Thank you for reporting it. :)

Edit: We worked hard to get it done before Vysp3r has to go. It's coming in a release today.

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 4, 2024

I just pushed an update to fix that issue

@polluxau
Copy link
Author

polluxau commented Oct 5, 2024

I see. So KDE is not able to render SVG icons correctly.

Shame on KDE.

I see that it's rendering the rounded square background and its gradient correctly. But it's only rendering a single pixel of the overlay "P+" shape, lol.

Our SVG icon is correct. You can see the proper rendering by visiting it in your web browser here:

https://github.com/Vysp3r/ProtonPlus/blob/main/data/logo/com.vysp3r.ProtonPlus.svg

So it's entirely KDE's fault. Which means we will have to generate bitmap PNG icons for KDE users then. But Vysp3r is gonna be gone for over a month, and I can't create releases without him, so it will have to wait. We will take care of it later. Thank you for reporting it. :)

Edit: We worked hard to get it done before Vysp3r has to go. It's coming in a release today.

Thank you for the quick and hard work! It's quite confusing that KDE doesn't have good svg support by now :/

@Arcitec
Copy link
Collaborator

Arcitec commented Oct 5, 2024

Thank you for the quick and hard work! It's quite confusing that KDE doesn't have good svg support by now :/

Yeah I'm glad we got it done today.

And yeah, it was definitely a lesson to not rely on SVG rendering. Thought everyone on Linux would be using some standardized SVG library to draw it correctly on every desktop, but apparently that's not how it works. Simple SVG icons are probably okay on KDE, but we used gradients and drop shadows and some of that clearly broke KDE's renderer.

Oh well, now we have PNGs so it'll look the same everywhere. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants