Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several Post-Launch Requests #1184

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Several Post-Launch Requests #1184

wants to merge 25 commits into from

Conversation

brianravi
Copy link
Contributor

Summary

Addressed several post-launch requests

Have you...

  • [x ] Linked this PR to an issue?
  • Written any automated tests?
  • [x ] Removed all debug statements?
  • Refactored your code to be maintainable?
  • [ x] Checked that Gemfile.lock and yarn.lock are't getting modified unintentionally?
  • Marked as Draft if it's unfinished?

The above things are not required, but appreciated.

@brianravi brianravi linked an issue Oct 27, 2023 that may be closed by this pull request
Fix and VCC commits should link to that commit on github. We can use the project commit url. #1182
Open
@brianravi brianravi removed a link to an issue Oct 27, 2023
Fix and VCC commits should link to that commit on github. We can use the project commit url. #1182
Open
This was linked to issues Oct 27, 2023
FOUC when opening a curation. #1165
Open
null as a string is appearing in various places #1166
Open
The "Yes/No" buttons could be prettier #1170
Open
I had a lot of trouble getting Related to work as a repeater. Wouldn't it be easier to have the repeater info right in the json instead of using a parent tree? #1172
Open
Image link isn't fingerprinting to get from the cdn - use image-url() instead of url() in the scss file. The file art.scss is a good reference for what this looks like. #1173
Open
Should be able to delete a curation from the front page #1175
Open
Refactoring: replace ajax calls with fetch #1176
Open
Repeaters should have delete buttons so you can remove an option #1181
Open
@brianravi brianravi linked an issue Oct 27, 2023 that may be closed by this pull request
Maybe instructions built into the page? An accordion entry with instructions on what to do that you can collapse. The project yml can have a bunch of useful links that people can use to investigate. #1179
Open
@brianravi brianravi linked an issue Oct 27, 2023 that may be closed by this pull request
The order of questions gets messed up when we use the shared.json thing. So maybe we have shared.json work as a dictionary, and then kernel.json could have a "use this from shared" key #1171
Open
@andymeneely
Copy link
Collaborator

Alright I'll review it this weekend and let you know if we need to meet Monday. Thank you!

@brianravi
Copy link
Contributor Author

brianravi commented Oct 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymeneely andymeneely Awaiting requested review from andymeneely

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
VHP Becomes a Thing
Status: 📋 TODO
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I had a lot of trouble getting Related to work as a repeater. Wouldn't it be easier to have the repeater info right in the json instead of using a parent tree? The order of questions gets messed up when we use the shared.json thing. So maybe we have shared.json work as a dictionary, and then kernel.json could have a "use this from shared" key The "Yes/No" buttons could be prettier null as a string is appearing in various places FOUC when opening a curation.
Image link isn't fingerprinting to get from the cdn - use image-url() instead of url() in the scss file. The file art.scss is a good reference for what this looks like. Should be able to delete a curation from the front page Refactoring: replace ajax calls with fetch Maybe instructions built into the page? An accordion entry with instructions on what to do that you can collapse. The project yml can have a bunch of useful links that people can use to investigate. Repeaters should have delete buttons so you can remove an option
2 participants
@brianravi @andymeneely