Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pre demo fixes #159

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix/pre demo fixes #159

merged 2 commits into from
Nov 13, 2024

Conversation

alepefe-vizz
Copy link
Collaborator

This pull request includes significant changes to the PostgresSurveyAnswerRepository, improvements to the test coverage for custom widgets, and updates to the usersContract to handle additional error responses. The key changes are detailed below.

Repository Updates:

  • Refactored the query logic in the PostgresSurveyAnswerRepository to improve parameter handling and SQL query structure. (api/src/infrastructure/postgres-survey-answers.repository.ts)

Test Coverage Enhancements:

  • Removed a test for anonymous users attempting to read custom widgets and added multiple new tests to cover various scenarios for reading custom widgets, including checks for authenticated and anonymous users. (api/test/e2e/users/custom-widgets/custom-widget-crud.spec.ts) [1] [2]
  • Updated the test for retrieving a widget with its filtered data by its id to use parameterized tests, improving test coverage and maintainability. (api/test/e2e/widgets/base-widgets.spec.ts)

Contract Updates:

  • Added 401 and 403 error responses to the usersContract to handle unauthorized and forbidden access attempts. (shared/contracts/users.contract.ts) [1] [2]

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-growth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:21pm

@alepefe-vizz alepefe-vizz merged commit dcab030 into dev Nov 13, 2024
5 checks passed
@alepefe-vizz alepefe-vizz deleted the fix/pre-demo-fixes branch November 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant