Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Cancelling SQL cell execution blocks Mimir #58

Open
okennedy opened this issue Jan 3, 2020 · 1 comment
Open

Cancelling SQL cell execution blocks Mimir #58

okennedy opened this issue Jan 3, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@okennedy
Copy link
Collaborator

okennedy commented Jan 3, 2020

Communication between Vizier and Mimir is synchronous, meaning that there's no way to asynchronously abort execution of a running Mimir query. The associated Vizier task aborts properly, but mimir keeps processing the query, blocking access to data until it finishes.

@okennedy okennedy added the bug Something isn't working label Jan 3, 2020
@okennedy okennedy changed the title Cancelling SQL cell execution blocks mimir Cancelling SQL cell execution blocks Mimir Jan 3, 2020
@okennedy okennedy modified the milestone: Vizier 1.0 Aug 12, 2020
@okennedy
Copy link
Collaborator Author

A simple way to address this would be to add some sort of sentinel keeping an eye on the connection state. If the connection is killed, then we kill the worker.

@mrb24 mrb24 self-assigned this Aug 12, 2020
@okennedy okennedy added this to the Vizier 1.0 milestone Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants