You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Widespread use of fixed-size buffers on the stack as strings is quite unsafe (too many examples to list but everywhere MAXPATH or MAXSTR is used).
Consider using _stprintf_s on Windows or snprintf on Unix, or using std::string (since it is being used elsewhere).
Also the ownership of _TCHAR * arguments pased to the API functions is unclear, it appears that they take ownership (and so these strings should not ever be deallocated by the caller).
Again consider using std::string since this is a C++ API. Otherwise mark them as const and copy the contents.
The text was updated successfully, but these errors were encountered:
Widespread use of fixed-size buffers on the stack as strings is quite unsafe (too many examples to list but everywhere
MAXPATH
orMAXSTR
is used).Consider using
_stprintf_s
on Windows orsnprintf
on Unix, or usingstd::string
(since it is being used elsewhere).Also the ownership of
_TCHAR *
arguments pased to the API functions is unclear, it appears that they take ownership (and so these strings should not ever be deallocated by the caller).Again consider using
std::string
since this is a C++ API. Otherwise mark them asconst
and copy the contents.The text was updated successfully, but these errors were encountered: