Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to_initialize(mapping, graph) #56

Closed
VEZY opened this issue Mar 18, 2024 · 1 comment
Closed

Improve to_initialize(mapping, graph) #56

VEZY opened this issue Mar 18, 2024 · 1 comment

Comments

@VEZY
Copy link
Member

VEZY commented Mar 18, 2024

The method is way too complicated and its implementation is very crude. We could do what it does with much fewer lines of code, and also more elegantly. For example, we should recursively search for variables that are inputs but computed at another scale, and it may even be possible to get the scale at which a variable is computed without giving it explicitly (just by searching for it as an output).

In this case we could have a method for MultiScaleModel with just the model, and without the mapping. Then our function would search for the variable at other scales, and if it finds several occurrences, it would guide the user on how to use the two-argument method of MultiScaleModel for the different possibilities.

@VEZY
Copy link
Member Author

VEZY commented Apr 4, 2024

Closed in f7de08b

@VEZY VEZY closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant