Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a sitemap.xml #1170

Open
BekahHW opened this issue May 2, 2024 · 8 comments · May be fixed by #1267
Open

feat: create a sitemap.xml #1170

BekahHW opened this issue May 2, 2024 · 8 comments · May be fixed by #1267
Assignees
Labels
Type: enhancement New feature or request

Comments

@BekahHW
Copy link
Member

BekahHW commented May 2, 2024

@eternalmaha
Copy link
Contributor

I'd like to take a shot at this issue.

@danieltott
Copy link
Member

Here's the Next.js docs about sitemaps:

https://nextjs.org/docs/app/api-reference/file-conventions/metadata/sitemap

I'd prefer though not to hand-write a sitemap, since it will easily get out of date as we update / add pages. This package looks promising: https://github.com/iamvishnusankar/next-sitemap

Or we could use our existing data functions and generate a sitemap via sitemap.ts

@danieltott danieltott added Type: enhancement New feature or request Status: Available This issue is free to be worked on (pick me!) labels Sep 30, 2024
@manya706
Copy link
Contributor

manya706 commented Oct 4, 2024

hey! can i work on this?

@danieltott
Copy link
Member

@manya706 its all you!

@danieltott danieltott removed the Status: Available This issue is free to be worked on (pick me!) label Oct 5, 2024
@manya706
Copy link
Contributor

manya706 commented Oct 5, 2024

Hi! while working on this, next-sitemap module can only be installed on stable versions of react and next.js , so i had to change version of the same. If you want I can move forward with a different approach too.

specific error faced-
\virtualcoffee.io> npm install next-sitemap
npm ERR! code EOVERRIDE
npm ERR! Override for react@canary conflicts with direct dependency

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\manya\AppData\Local\npm-cache_logs\2024-10-05T17_56_19_413Z-debug-0.log

@danieltott
Copy link
Member

@manya706 we definitely need the versions we have for react and next. Might be able to use the overrides key in package.json to tell npm to ignore that requirement though 👍

@danieltott
Copy link
Member

@manya706 also please use pnpm to install/manage dependencies

@manya706
Copy link
Contributor

manya706 commented Oct 7, 2024

okay thanks :)

@manya706 manya706 linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
4 participants