Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor link on member map <Popup> to member block #1038

Closed
2 tasks done
danieltott opened this issue Oct 6, 2023 · 2 comments · Fixed by #1039
Closed
2 tasks done

Add anchor link on member map <Popup> to member block #1038

danieltott opened this issue Oct 6, 2023 · 2 comments · Fixed by #1039
Assignees
Labels
Hacktoberfest 2023 Issue for Full Member For full members who have attended a coffee session, filled out the new member for, and are in slack Type: enhancement New feature or request

Comments

@danieltott
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Issue Context

It'd be cool in the popover on the map pins to be able to link to the user's info.

image

Proposed solution

The member cards already have an id attached to them:

id={`member_${member.github}`}

So we can update the Popover in the map to have an anchor-style link to the card (<a href="#member_danieltott">Dan Ott</a>)

The popovers are created here:

https://github.com/Virtual-Coffee/virtualcoffee.io/blob/bddbe981153d7f3fa1c06bdf104dc122f3b0d9f4/app/components/MemberMap.tsx#L26-L34C14

Alternatives Considered

No response

Additional Resources

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Virtual Coffee community
@danieltott danieltott added Type: enhancement New feature or request Status: Needs Triage This issue hasn't been reviewed by maintainers yet. Issue for Full Member For full members who have attended a coffee session, filled out the new member for, and are in slack Hacktoberfest 2023 and removed Status: Needs Triage This issue hasn't been reviewed by maintainers yet. labels Oct 6, 2023
@piotrszymaniec
Copy link
Contributor

could i take it ? :)

@danieltott
Copy link
Member Author

@piotrszymaniec it's all you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest 2023 Issue for Full Member For full members who have attended a coffee session, filled out the new member for, and are in slack Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants