Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

possible exception with minification #76

Closed
kamilgarey opened this issue Mar 29, 2019 · 3 comments
Closed

possible exception with minification #76

kamilgarey opened this issue Mar 29, 2019 · 3 comments

Comments

@kamilgarey
Copy link
Contributor

js minification now take scripts in alphabetical order. Usually files need only reference to angular module storefrontApp (over dependencies comes thru angular DI) . As it is declared in app.js which usually comes first in minification order we have no problems. But if we create a file who comes first in order and reference to module (which we usually do) we'll got angular error in storefront after minification .

Steps to reproduce

  1. add "answer.js" to assets/js which contains
    "
    angular.module('storefrontApp');
    "
  2. minify
    3.Update browser cache.
@yecli yecli added this to the Operations milestone Mar 29, 2019
@yecli yecli self-assigned this Mar 29, 2019
@yecli
Copy link
Contributor

yecli commented Apr 2, 2019

Moved to "On hold" as theme bundling is going to be reworked.

@eMazeika
Copy link

eMazeika commented Apr 9, 2019

that's a "well known old issue". Hopefully, we can get new recommendations / solution on this after "reworked".

@yecli yecli removed their assignment Apr 9, 2019
@t13ka t13ka removed this from the Operations milestone Dec 25, 2019
@tatarincev
Copy link
Contributor

This issue has been closed because it has no longer relevant to the current operation nature of issues.
You may reopen this issue if it has been closed in error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants