You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw bunch of deprecated code in knex, that is trying to check and give warnings if invalid parameters are passed to tarn (checked parameter list actually didn't match with tarn...).
To me it would be more reasonable to do parameter validation by tarn instead of trying to keep up with correct attributes in knex side. Probably knex had that code, because of its old habit of changing pool on every release.
Downside of this is that throwing an error on invalid parameter would be a breaking change. I could live with that though.
The text was updated successfully, but these errors were encountered:
I saw bunch of deprecated code in knex, that is trying to check and give warnings if invalid parameters are passed to tarn (checked parameter list actually didn't match with tarn...).
To me it would be more reasonable to do parameter validation by tarn instead of trying to keep up with correct attributes in knex side. Probably knex had that code, because of its old habit of changing pool on every release.
Downside of this is that throwing an error on invalid parameter would be a breaking change. I could live with that though.
The text was updated successfully, but these errors were encountered: