From e87dac697247affd35df04b15dde8bb410362d24 Mon Sep 17 00:00:00 2001 From: Melissa Hart <48496458+MelissaDTH@users.noreply.github.com> Date: Thu, 25 Jan 2024 17:28:20 +0100 Subject: [PATCH] feat(a11y): update button role and html structure of account and player pages (#47) --- .../ui-react/src/components/Account/Account.tsx | 2 +- .../Account/__snapshots__/Account.test.tsx.snap | 10 +++++----- .../ui-react/src/components/Button/Button.tsx | 2 +- .../Button/__snapshots__/Button.test.tsx.snap | 1 + .../CancelSubscriptionForm.tsx | 1 + .../CancelSubscriptionForm.test.tsx.snap | 2 ++ .../__snapshots__/CheckoutForm.test.tsx.snap | 1 + .../__snapshots__/ConfirmationForm.test.tsx.snap | 1 + .../EditCardPaymentForm/EditCardPaymentForm.tsx | 1 + .../src/components/EpgChannel/EpgChannelItem.tsx | 1 + .../Filter/__snapshots__/Filter.test.tsx.snap | 4 ++++ .../Header/__snapshots__/Header.test.tsx.snap | 2 ++ .../NoPaymentRequired.test.tsx.snap | 1 + .../PayPal/__snapshots__/PayPal.test.tsx.snap | 1 + .../Payment/__snapshots__/Payment.test.tsx.snap | 1 + .../__snapshots__/PaymentFailed.test.tsx.snap | 1 + .../RenewSubscriptionForm.tsx | 1 + .../RenewSubscriptionForm.test.tsx.snap | 2 ++ .../ResetPasswordForm/ResetPasswordForm.tsx | 2 +- .../ResetPasswordForm.test.tsx.snap | 2 ++ .../__snapshots__/ShareButton.test.tsx.snap | 1 + .../SubscriptionCancelled.test.tsx.snap | 1 + .../SubscriptionRenewed.test.tsx.snap | 1 + .../src/components/VideoLayout/VideoLayout.tsx | 2 +- .../Welcome/__snapshots__/Welcome.test.tsx.snap | 1 + .../pages/User/__snapshots__/User.test.tsx.snap | 16 +++++++++++----- 26 files changed, 47 insertions(+), 14 deletions(-) diff --git a/packages/ui-react/src/components/Account/Account.tsx b/packages/ui-react/src/components/Account/Account.tsx index 064bb1c71..92b11f7ce 100644 --- a/packages/ui-react/src/components/Account/Account.tsx +++ b/packages/ui-react/src/components/Account/Account.tsx @@ -194,6 +194,7 @@ const Account = ({ panelClassName, panelHeaderClassName, canUpdateEmail = true } return ( <> +

{t('nav.account')}

{[ formSection({ @@ -214,7 +215,6 @@ const Account = ({ panelClassName, panelHeaderClassName, canUpdateEmail = true } }, content: (section) => ( <> -

{t('nav.account')}

> renders and matches snapshot 1`] = `
+

+ nav.account +

> renders and matches snapshot 1`] = ` class="_flexBox_1c1c63" novalidate="" > -

- nav.account -

diff --git a/packages/ui-react/src/components/Button/Button.tsx b/packages/ui-react/src/components/Button/Button.tsx index fc4bf0c72..842e92934 100644 --- a/packages/ui-react/src/components/Button/Button.tsx +++ b/packages/ui-react/src/components/Button/Button.tsx @@ -42,7 +42,7 @@ const Button: React.FC = ({ size = 'medium', disabled, busy, - type, + type = 'button', to, as = 'button', onClick, diff --git a/packages/ui-react/src/components/Button/__snapshots__/Button.test.tsx.snap b/packages/ui-react/src/components/Button/__snapshots__/Button.test.tsx.snap index 766a87a85..aa5e13b5a 100644 --- a/packages/ui-react/src/components/Button/__snapshots__/Button.test.tsx.snap +++ b/packages/ui-react/src/components/Button/__snapshots__/Button.test.tsx.snap @@ -4,6 +4,7 @@ exports[`
diff --git a/packages/ui-react/src/components/CancelSubscriptionForm/__snapshots__/CancelSubscriptionForm.test.tsx.snap b/packages/ui-react/src/components/CancelSubscriptionForm/__snapshots__/CancelSubscriptionForm.test.tsx.snap index e741084ab..e1f960683 100644 --- a/packages/ui-react/src/components/CancelSubscriptionForm/__snapshots__/CancelSubscriptionForm.test.tsx.snap +++ b/packages/ui-react/src/components/CancelSubscriptionForm/__snapshots__/CancelSubscriptionForm.test.tsx.snap @@ -14,6 +14,7 @@ exports[` > renders and matches snapshot 1`] = `
diff --git a/packages/ui-react/src/components/Filter/__snapshots__/Filter.test.tsx.snap b/packages/ui-react/src/components/Filter/__snapshots__/Filter.test.tsx.snap index 6bf873a36..8fc29d1be 100644 --- a/packages/ui-react/src/components/Filter/__snapshots__/Filter.test.tsx.snap +++ b/packages/ui-react/src/components/Filter/__snapshots__/Filter.test.tsx.snap @@ -10,6 +10,7 @@ exports[` > renders Filter 1`] = `