You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into issues with this in cases where -include was used, or when there was a space between -I/-include and the actual path. In my particular case, I found that if I didn't do any argument filtering, but just used cmd['command'].split()[1:-3] instead of all the arguments, it worked. This filtered out the compiler executable (the first argument) and the '-o output_file source_file` part of the command. While this fixed my issue, this wouldn't generally fix the issue as it's relying on those three tokens being at the end of the command, which is why I didn't submit a PR for it.
I also ran into issues, because some arguments contained single quotes that would have been removed on the command line, i.e. -DFOO='BAR', and I needed to do x.replace("'", '') to fix it.
The text was updated successfully, but these errors were encountered:
Thank you for caring about this project. As you can see, this has not been maintained or used for 5 years. Would you like having contributor privileges?
I think you would do a much better job at fixing the bugs you have found than me, given that you just ran those investigations and have them in your mind, while I forgot it all and feel like I have never seen this code in my life.
This is the current way we're filtering the command arguments before passing it to
index.parse()
:I ran into issues with this in cases where
-include
was used, or when there was a space between-I
/-include
and the actual path. In my particular case, I found that if I didn't do any argument filtering, but just usedcmd['command'].split()[1:-3]
instead of all the arguments, it worked. This filtered out the compiler executable (the first argument) and the '-o output_file source_file` part of the command. While this fixed my issue, this wouldn't generally fix the issue as it's relying on those three tokens being at the end of the command, which is why I didn't submit a PR for it.I also ran into issues, because some arguments contained single quotes that would have been removed on the command line, i.e.
-DFOO='BAR'
, and I needed to dox.replace("'", '')
to fix it.The text was updated successfully, but these errors were encountered: