Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshare broadcasts system-wide audio, not just that of the application. #569

Open
bobismymom opened this issue May 2, 2024 · 12 comments
Labels
upstream related to a dependency, for example electron wontfix This will not be worked on

Comments

@bobismymom
Copy link

Describe the bug

When streaming any application using Vesktop, audio from other applications is being picked up and broadcasted.

Expected behavior

Vesktop streaming only the audio of the application I selected to screenshare.

Desktop (please complete the following information):

  • OS/Distro: Windows 10 LTSC 21H2

Additional Context

I tried streaming VLC, Foobar2000, a variety of games and the issue persists.

@bobismymom bobismymom added the bug Something isn't working label May 2, 2024
@Vendicated
Copy link
Member

yes this is intended

i don't think it's possible to stream just one window with electron api

@PolisanTheEasyNick
Copy link
Contributor

Indeed, using electron API we can stream either all sound from Windows system or sound from one tab:
image
For now, we are setting audio parameter just to loopback:
https://github.com/Vencord/Vesktop/blob/main/src/main/screenShare.ts#L80

@Vendicated
Copy link
Member

that api has no option to choose a custom window. WebFrameMain refers to an electron frame, aka a frame of your own app. not other apps

@Vendicated Vendicated added wontfix This will not be worked on upstream related to a dependency, for example electron labels May 2, 2024
@PolisanTheEasyNick
Copy link
Contributor

that api has no option to choose a custom window. WebFrameMain refers to an electron frame, aka a frame of your own app. not other apps

Ohh, I see now. Anyway there's no way to choose another sound source :(

@Vendicated Vendicated removed the bug Something isn't working label Jun 1, 2024
@Tiagoquix

This comment was marked as off-topic.

@Vendicated

This comment was marked as off-topic.

@KIRUYXAN
Copy link

KIRUYXAN commented Oct 24, 2024

That is, did I understand correctly that this cannot be fixed?

@Communified
Copy link

I love this program, but this being an "intended" feature is almost dealbreaking for the app; I can no longer stream in vc with audio without them being able hear all other sources of audio, INCLUDING themselves in the vc; which makes audio completely pointless. If there's truly no fix due to the api, it sounds like the api needs to be different for an issue as major as this; everything else functions as intended and how I'd expect within native discord. In discord, even desktop audio capture does NOT include discord; meaning you hear everything EXCEPT others voices, which is much more acceptable. From what you said does that mean it's impossible to fix even via a plugin strictly due to what the program is built off?

@Covkie Covkie marked this as a duplicate of #1059 Jan 23, 2025
@CloveTwilight3
Copy link

Ope yeah I didnt see this one, didn't show up when I searched, sorry peeps, it's kinda annoying, and yes I wish there was a fix, but if ya can't fix it, that's all good. Hope there becomes a fix in the future! ❤

@quadrinex
Copy link

I maybe have a solution (for windows) tho it's not optimal but what if we set the output of a window to a virtual audio cable¹, loopback the audio¹ and use the virtual microphone for the stream.

1.Can be done within windows settings

@CloveTwilight3
Copy link

I maybe have a solution (for windows) tho it's not optimal but what if we set the output of a window to a virtual audio cable¹, loopback the audio¹ and use the virtual microphone for the stream.

I had a go looking at this, commit 4db9f25. Did you mean something like this?

@quadrinex
Copy link

I maybe have a solution (for windows) tho it's not optimal but what if we set the output of a window to a virtual audio cable¹, loopback the audio¹ and use the virtual microphone for the stream.

I had a go looking at this, commit 4db9f25. Did you mean something like this?

I'm not really good at coding but from what I understand that what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream related to a dependency, for example electron wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

8 participants