Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a notebook should remove it completely #3915

Open
predictiple opened this issue Nov 24, 2024 · 0 comments
Open

Deleting a notebook should remove it completely #3915

predictiple opened this issue Nov 24, 2024 · 0 comments

Comments

@predictiple
Copy link
Contributor

predictiple commented Nov 24, 2024

Currently (v0.73.3) the Delete Notebook button removes the notebook from the notebooks list but leaves the notebook itself active in the lower pane.

Screenshot from 2024-11-24 10-38-16

Additionally I think that deleting notebooks should also remove them from disk, since that would probably be in line with most users' expectations. Deleted notebooks that aren't deleted from disk, especially in large deployments, might needlessly waste a lot of disk space. Daily backups will already likely contain most historical notebooks in case recovery is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant