Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid building custom Caddy-based image for Docker deployment #749

Open
bkis opened this issue Feb 25, 2025 · 2 comments
Open

Avoid building custom Caddy-based image for Docker deployment #749

bkis opened this issue Feb 25, 2025 · 2 comments
Assignees
Labels
deferred Now's not the right time for this enhancement New feature or request maintenance Keep it in good shape

Comments

@bkis
Copy link
Member

bkis commented Feb 25, 2025

Currently, we build a custom image for serving the client and proxying requests to the API based on caddy:x.x-alpine. The image build copied the client files from a previous build step. But as the final prod image is basically a vanilla Caddy image, we should instead do the following:

  1. Build the client using a stock node image and store the distribution files locally (as opposed to in an image)
  2. Run a stock Caddy image with two volumes (bind mounts) giving the container access to the Caddyfile and the static client files
@bkis bkis added enhancement New feature or request maintenance Keep it in good shape labels Feb 25, 2025
@bkis bkis added this to the VedaWeb 2.0 launch milestone Feb 25, 2025
@bkis bkis self-assigned this Feb 25, 2025
@bkis
Copy link
Member Author

bkis commented Feb 25, 2025

Also, adjust the setup documentation accordingly!

@bkis
Copy link
Member Author

bkis commented Feb 28, 2025

This is trickier than expected, as our "one .env file provides all configuration"-approach isn't easily adaptable for e.g. a build.sh script that runs the client build in a container.

As there are more pressing issues right now and the technical as well as conceptual overhead of the current solution are negligible, this will be deferred.

@bkis bkis added the deferred Now's not the right time for this label Feb 28, 2025
@bkis bkis removed this from the VedaWeb 2.0 launch milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred Now's not the right time for this enhancement New feature or request maintenance Keep it in good shape
Projects
None yet
Development

No branches or pull requests

1 participant