-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: nginx apt-key expired #2709
Comments
Thanks for opening your first issue here! Be sure to follow the issue template and include your OS/Vagrant/VVV versions! Don't forget you can get support in the VVV slack at https://varyingvagrantvagrants.org/docs/en-US/slack/
|
Workaround for fixing a VVV environment that has been provisioned at least once before. Not sure if this is best practice, but it did work for me: vagrant up
vagrant ssh
curl https://nginx.org/keys/nginx_signing.key | gpg --dearmor | sudo tee /usr/share/keyrings/nginx-archive-keyring.gpg >/dev/null
apt-key add /usr/share/keyrings/nginx-archive-keyring.gpg
exit
vagrant reload --provision |
https://github.com/Varying-Vagrant-Vagrants/VVV/blob/develop/provision/core/nginx/apt-keys/nginx_signing.key is indeed the file that needs updating
|
@jcdevnj can you help test the PR? if we swap the key out as is it won't fix it for existing users as it'll only add the key if it there is no nginx key, I've tried explicitly checking for the old key in the PR, currently testing |
hmm CI failed with an invalid keyring error, I'm wondering if I've messed up the GPG commit |
Fixed the CRLF issue and configured git to treat GPG keyrings as binary |
I'm happy with things from my testing but before I merge the fix in I want to see someone else test that PR and check things. Once it's merged there'll be a VVV release to make sure it's on the stable branch |
@tomjn Just tested your branch and provisioning & re-provisioning works for me now! |
What was The Command Used To Provision
What Kind of VVV Provision Was This
This was a fresh install
Logs/What Broke
The 'main' provisioner ran into problems as the nginx signing key is expired. GPG throws an error and the provisioner fails.
Possible Solution
Replace
provision/core/nginx/apt-keys/nginx_signing.key
with the most recent key, as described in this ticket. Doesn't fix the issue for environments that have already been provisioned though as simply replacing the key in this directory doesn't make the provisioner succeed.Steps to Reproduce (for bugs)
Follow the "How to Use" instructions in
README.md
of this repo.Log
The text was updated successfully, but these errors were encountered: