Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle nginx config install failures #2604

Closed
tomjn opened this issue Apr 29, 2022 · 0 comments · Fixed by #2605
Closed

Gracefully handle nginx config install failures #2604

tomjn opened this issue Apr 29, 2022 · 0 comments · Fixed by #2605
Milestone

Comments

@tomjn
Copy link
Member

tomjn commented Apr 29, 2022

When a user puts a typo in their custom nginx configs and reprovisions, all reprovisioning fails.

Instead, it should attempt to use the config, see that it fails, run nginx -t and remove the config so that the dashboard and other sites are still reachable. This also opens the possibility that we can continue provisioning and log the error somewhere and show it in the dashboard

@tomjn tomjn added this to the 3.10 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant