Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR: Investigate splitting assembly #567

Open
fhcarter opened this issue Feb 19, 2025 · 2 comments
Open

FHIR: Investigate splitting assembly #567

fhcarter opened this issue Feb 19, 2025 · 2 comments
Assignees
Labels

Comments

@fhcarter
Copy link
Collaborator

At present, we define a single assembly that has myriad configuration properties, mostly to obtain the information we need for various forms of authentication. Since not all properties can be required, they are all optional & we check at run time.

Though code management will be painful, we may want to have separate assemblies for the various authentication types. That's quite ugly, too. In practice, this may be something we wait and determine via demand. That is, leave it as is. If we find that, in practice, it's confusing and/or difficult to support, then we split. Otherwise not.

Placing this issue as a place for somewhat public discussion.

@fhcarter fhcarter added the ToDo label Feb 19, 2025
@fhcarter fhcarter self-assigned this Feb 19, 2025
@fhcarter
Copy link
Collaborator Author

Issues with this:

  • development may be a pain, but that can probably be ameliorated via gradle tasks.
  • Confusing to customers as they have to look thru the catalog to find the fhirConnectionNone vs. fhirConnectionBasic vs. fhirConnectionOauth vs. fhirConnectionSmart vs. fhirConnectionUDAP or something like that. And if things change, uninstall & install a new one. ... Because
  • Confusion in code since there will be multiple assemblies that bring in the same service, source, etc. Anyone who tries to install > 1 of these may run into issues. Just not set up for things to work this way.
    • May be ameliorated by some clever renaming of things, but this will all be rather confusing and, potentially, brittle.

@fhcarter
Copy link
Collaborator Author

Other option may be to have a set of layered set of things to install. This tends to confuse people (from experience with the Camel Kamelet-based assemblies), but may prove manageable. But there would be interrelationships that may result in code compilation errors (sources missing, etc.), that will make things look ungainly.

@fhcarter fhcarter changed the title Investigate splitting assembly into multiple ones FHIR: Investigate splitting assembly into multiple ones Feb 19, 2025
@fhcarter fhcarter changed the title FHIR: Investigate splitting assembly into multiple ones FHIR: Investigate splitting assembly Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant