Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gnome Shell] Steam closes after clicking "close" button in Shell's overlay #53

Closed
Majkl578 opened this issue Dec 20, 2012 · 23 comments
Closed
Assignees
Labels

Comments

@Majkl578
Copy link

Steam closes and terminates itself after clicking on "close" ("X") button in Gnome Shell's overlay. This also happens when more than one window (e.g. Friends and Library) are opened which is weird and should close only the one window. In normal mode (clicking window's close) it is same as #11.

Debian experimental x86_64, Gnome Shell 3.6.

@swiftgeek
Copy link

It happens in every DE/WM
Instead of shell's overlay it's a taskbar or for example alt+f4 (but 2nd one is user specific ;) )

@mdaffin
Copy link
Contributor

mdaffin commented Dec 20, 2012

Seeing the same issue on kde, I have set kwin to show the window decoration and clicking the X on that closes steam.

@gdrewb-valve
Copy link
Contributor

Can you give me more detail on exactly what the unexpected behavior is? Are you asking if steam should keep running when its window is closed?

@swiftgeek
Copy link

"Are you asking if steam should keep running when its window is closed?"
Only when appindicator icon is present //This should be fixed, because as a result behaviors from below would be coherent

Also behaviors aren't quite coherent - "×" from wm will terminate steam and "×" from steam window will just minimize
//Steam shouldn't try to fix that — otherwise we would run into troubles on logout/shutdown

@gdrewb-valve
Copy link
Contributor

Canonical is working on libappindicator so that will improve over time, such as getting a 64-bit version.

The WM closure behavior is by-design, but we can hang on to the feedback that it's confusing.

@swiftgeek
Copy link

libappindicator is already compiled for multilib in archlinux and it works
Canonical should (IMO move to CMAKE and then) fix their build system for that package -.- it's utterly terrible since it doesn't allow for easy disable of python binding which would be ridiculous to make on multilib (and this is what breaks compilation without my patch).

Patch https://gist.github.com/4293782
Working package https://aur.archlinux.org/packages/lib32-libappindicator/ (1st comment is from sb who ***** up own toolchain for multilib... some people just have talent for such stuff)

@Majkl578
Copy link
Author

@gdrewb-valve:
As I said: " This also happens when more than one window (e.g. Friends and Library) are opened which is weird and should close only the one window. "
So I have a Friends window and Library window. That is two steam windows. Now when I close Friends window from Shell's overlay, only Library remains. That is OK. But, when I close Library window, Friends window should be left open, but instead both are closed and steam is terminated.

@swiftgeek
Copy link

And this is still only possible to fix after steam will sense whether appindicator is working or not.
Otherwise it will work in strange ways.

If steam can't sense it right now due to libappindicator mess, then maybe some argument / evn variable should be invented to force steam to close only windows, without terminating a whole process

eg. steam --force-windowless

This would allow developers to move on in this buggy area…

EDIT: FUNNY thing — (only ofc) small mode now works as expected!

@gdrewb-valve
Copy link
Contributor

@Majkl578 :
When you say "Library window" you mean the main Steam window, correct? That window controls the application and the Friends window is subsidiary to it, they are not peers.

@gdrewb-valve
Copy link
Contributor

I've been playing around and it looks like we may have an issue in the client when processing WM_DELETE_WINDOW, which is what I'm assuming the Gnome Shell is sending. I'll check into it more.

@gdrewb-valve
Copy link
Contributor

We are going to change the behavior to last-window-closes-app in the next client update.

@LiamDawe
Copy link
Contributor

LiamDawe commented Jan 6, 2013

I take it that will fix it so if you click the cross the app will actually close now and not minimize? If so a tray icon is really needed!

@swiftgeek
Copy link

"We are going to change the behavior to last-window-closes-app in the next client update."
Always or only when tray icon is not present?

There shouldn't be any problems with replacing WM_DELETE_WINDOW behavior (in above comments i thought about SIGTERM...)

@gdrewb-valve
Copy link
Contributor

The new last-window-closes-app behavior will only apply to when the window manager sends WM_DELETE_WINDOW, not when using the regular close buttons in the steam UI. It will always happen regardless of the tray icon. This is a temporary behavior until the tray icon is more reliable.

There is a tray icon, it just has multi-arch problems that Canonical is working on and so doesn't show up on 64-bit, which most people are running. When an update for that is released it will start working on 64-bit. We are also working with Canonical to ensure that their window manager compatibility is in place so that the indicator extends beyond Unity.

@swiftgeek
Copy link

How canonical can work on this problem when i have already solved it :/ (quite ugly, but it works - good enough to make a package)

/patch was created 22 days ago/
Since You already have own repo, maybe u should make own multilib package for appindicator? It would be a lot faster than waiting for cannonical

@Majkl578
Copy link
Author

Majkl578 commented Feb 6, 2013

This is still unresolved for me, can you reopen it?

Even when I have a tray icon and STEAM_FRAME_FORCE_CLOSE is set, closing last window in Shell's overlay makes Steam quit (whereas closing it normally does not).

@gdrewb-valve
Copy link
Contributor

That's the expected result, are you asking if we have turned off the temporary behavior? That'll be a while out.

@Majkl578
Copy link
Author

Majkl578 commented Feb 6, 2013

Well, it's not in sync with the behavior of closing windows using "x".
I understand the need for this behavior, but having at least some environment switch would probably be useful. :)

@AaronOpfer
Copy link

This bug is really irritating, from a UX perspective. I would never expect the behavior of a program's close box to differ substantially from using a window manager's shortcut to that closebox action. When I'm trying to clear my workspace, I close "Friends" and "Library" from the window manager screen (where I can find them no matter the current z-order of windows), but this causes Steam to exit entirely. I don't realize it until I go to play a game, and so during that whole duration of time, none of my steam friends were able to contact me. Really big issue, IMO.

@0x1f415
Copy link

0x1f415 commented Mar 21, 2016

I use i3wm and using the keyboard shortcut to close the window also shuts down steam.

I'd like to suggest a command-line flag to hide the main window, functionally identical to the steam client's close button, so that users can at least override the window manager's default behavior for the main steam window only in their configs.

roping in some other related issue threads: #1040 #2160 #1879

@rindo-eiji
Copy link

is it normal that I still have this issue?

@Allavaz
Copy link

Allavaz commented Sep 21, 2021

I still have this issue. Expected behavior for me would be that when I close from overview/taskbar/alt-f4 it doesn't actually close Steam, it just closes the window, like in Discord for example. The worst part is when you have only a chat window open and a game running, you do alt-f4 on the chat window and it closes Steam and your game goes with it, kinda annoying.

@kisak-valve
Copy link
Member

Hello @rindo-eiji, @Allavaz, this issue is currently being tracked at #2685.

@ValveSoftware ValveSoftware locked and limited conversation to collaborators Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests