We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When property cropSize is changed in same time as zoom, computeSizes is not called. So state of cropSize is not updated.
Expected behavior If property cropSize has changed, it will update Resizer state cropSize
We are using onMediaLoaded callback to calculate zoom and cropSize. Also we use range sliders to manipulate width, height, zoom.
I tried move condition in componentDidUpdate to be separately and called everytime when cropSize changed and it helps. Should I create PR for this?
The text was updated successfully, but these errors were encountered:
Indeed, having all the conditions tied together doesn't seem right. Most of else should be removed I think.
By the way, why are you using cropSize instead of aspect?
cropSize
aspect
Sorry, something went wrong.
I made some local patch for our case, but if i will have time i'll will try investigate how can be helpful aspect.
No branches or pull requests
Describe the bug
When property cropSize is changed in same time as zoom, computeSizes is not called. So state of cropSize is not updated.
Expected behavior
If property cropSize has changed, it will update Resizer state cropSize
We are using onMediaLoaded callback to calculate zoom and cropSize. Also we use range sliders to manipulate width, height, zoom.
I tried move condition in componentDidUpdate to be separately and called everytime when cropSize changed and it helps. Should I create PR for this?
The text was updated successfully, but these errors were encountered: