Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

original-size set to false and zoom set to 1 no longer working as before #524

Closed
jain-amit opened this issue Oct 17, 2019 · 1 comment
Closed
Labels

Comments

@jain-amit
Copy link
Contributor

- [x] Regression (a behavior that used to work and stopped working in a new release)

Previously in 5.3.4
Setting original-size to false with a zoom of 1 would set the PDF width to be size of the container. After zooming in or out regardless of whether PDF was larger or smaller than the container, the PDF would always resize to container width when original-size is set to false.

Observed new behaviour in 6.0.0:
Behaviour works correctly when original-size is true.

When original-size is false, there is Inconsistent behaviour depending whether PDF is larger or smaller than the container.

On initial load, the width of the PDF is set to original size even though original-size is set to false.

When zooming in so that the PDF is larger that container width, setting zoom to 1 will resize to container width. This matches previous behaviour.

When zooming out (making PDF smaller than container) then setting zoom to 1 does not resize the PDF.

@stale
Copy link

stale bot commented Jul 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2020
@stale stale bot closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant