-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: bionic support for vscodium-reh-linux-arm64 #2157
Comments
Not sure why, it use the same version as for
Which node version are you using? |
That possible never worked... from my edit:
|
@GitMensch Which node version are you using? |
@daiyam 1.96 server is completely broken, just go this issue reported on remote-ssh jeanp413/open-remote-ssh#183. 1.96 is shipping node 16, which as I understand vscodium is using this older version of node to support older glibc, but with 1.96 vscode uses a newer version of undici as a dependancy that imports I think vscode smoke test should've caught this, are those run when running the release pipeline? |
No |
Can you test the version |
This one can't work, because it is about running vscodium-reh on bionic (android) and in vscodium-reh-linux-arm64:
|
Oh! Sorry It haven't occured to me it was for android, so it's a new arch. |
So sorry, when I read Is there a nodejs version available for Android? Maybe https://github.com/nodejs-mobile/nodejs-mobile. But I can't test it, I don't have any recent Android. |
nodejs-mobile just provides libnode.so, we would want the node binary. I guess the biggest issue is to also build all the node modules for bionic... Maybe it is enough to use I just tried to manually run |
Describe the bug
reh is not starting because of missing dependencies (checking with
ldd
- all depending libraries not found)Please confirm that this problem is VSCodium-specific
Please confirm that the issue/resolution isn't already documented
To Reproduce
node
ldd
-> all depending libraries missingExpected behavior
of course "works"
Workaround
I've installed
node
manually, then replaced the non-working node binary with a shell scriptnode $*
(thinking about that a symlink may have been more reasonable)Note: While reh works "in general" the pty host and many extensions don't work - as this is a clang only system that has only libc++, not libcstd++.
Additional context
I don't know if a previous version did work or if this was the same before.
But Ideally we could bundle a node that is all self-contained (or have a version without it).
CC'ing @jeanp413 to let him know (maybe the start script of
open-remote-ssh
could check first if the server directorynode
works and if not give a warning and then rename that (at least if a system-wide node exists)?The text was updated successfully, but these errors were encountered: