Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCodium Wayland using Wayland icon instead of app icon #2127

Open
2 tasks done
y0nei opened this issue Nov 26, 2024 · 12 comments
Open
2 tasks done

VSCodium Wayland using Wayland icon instead of app icon #2127

y0nei opened this issue Nov 26, 2024 · 12 comments
Labels
bug Something isn't working downstream something awry downstream

Comments

@y0nei
Copy link

y0nei commented Nov 26, 2024

Describe the bug
This issue popped up just recently, not sure which update but this wasnt the case before.
This doesnt happen with code-oss, package installed via pacman and AUR, both have same issue.

Please confirm that this problem is VSCodium-specific

  • This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

To Reproduce
Steps to reproduce the behavior:

  1. Run KDE Wayland
  2. Install vscodium
  3. Run "vscodium - Wayland"

Expected behavior
App having the previous assigned icon.

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: Linux 6.12.1-1-cachyos-eevdf GNU/Linux
  • Architecture: x86_64
  • Version: 1.95.3
  • App Manager: pacman, yay
  • Sandboxed: no

Additional context
Add any other context about the problem here.

@y0nei y0nei added the bug Something isn't working label Nov 26, 2024
@daiyam daiyam added the downstream something awry downstream label Nov 26, 2024
@daiyam
Copy link
Member

daiyam commented Nov 26, 2024

vscodium-bin isn't managed by us.

@crueter @Icelk Can you help?

@y0nei
Copy link
Author

y0nei commented Nov 26, 2024

vscodium-bin isn't managed by us.

@crueter @Icelk Can you help?

The vscodium-git AUR package also has this issue

@Icelk
Copy link

Icelk commented Nov 26, 2024

That's odd. The icon doesn't seem to be changed 🤔 . Made it copy to the "normal" icon place in linux now too. @y0nei can you try the new version in the AUR?

@y0nei
Copy link
Author

y0nei commented Nov 26, 2024

That's odd. The icon doesn't seem to be changed 🤔 . Made it copy to the "normal" icon place in linux now too. @y0nei can you try the new version in the AUR?

Yea now it has the correct icon lol, but why is the desktop file named codium-wayland instead of vscodium-wayland in /usr/share/applications now? I installed the vscodium-bin package that was the newly updated one.

@Icelk
Copy link

Icelk commented Nov 26, 2024 via email

@Icelk
Copy link

Icelk commented Nov 26, 2024 via email

@crueter
Copy link

crueter commented Nov 26, 2024

Wayland requires icons to be in the standard XDG directory as far as I can tell, its icon spec is weird and doesn't at all follow X11's.

Not sure about the naming thing because I haven't touched the package in a while, totally forgot I was even the maintainer

@Icelk
Copy link

Icelk commented Nov 28, 2024

@y0nei
Regarding the naming, it has been like that for at least half a year. But either way .desktop file naming is pretty arbitrary right?

@y0nei
Copy link
Author

y0nei commented Nov 28, 2024

@y0nei Regarding the naming, it has been like that for at least half a year. But either way .desktop file naming is pretty arbitrary right?

Hmm that's funny, just now from that update that fixed the icon issue had the .desktop file names changed for me.
Anyway, should i close this issue now or should i wait till the same fix gets pushed to the regular vscodium packages' PKGBUILD too?

@crueter
Copy link

crueter commented Nov 29, 2024

@daiyam manages those two packages, and it doesn't seem to be fixed just yet.

@noonsleeper
Copy link
Contributor

@daiyam I think this is a problem that I fixed on flatpak by a patch https://github.com/flathub/com.vscodium.codium/blob/master/patches/package.json.patch the problem is that the app is reporting a different desktopName then gnome/kde or another wayland compositor try to use that name to match the icon.

@noonsleeper
Copy link
Contributor

noonsleeper commented Dec 13, 2024

if you use gnome you can use looking glass to inspect the window properties https://wiki.gnome.org/Projects/GnomeShell/LookingGlass

image

wmclass needs to match with the desktopName in order to load the correct icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working downstream something awry downstream
Projects
None yet
Development

No branches or pull requests

5 participants