Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed block was expanded when press J on the first line. #1936

Closed
lilei opened this issue Jul 19, 2017 · 6 comments
Closed

Collapsed block was expanded when press J on the first line. #1936

lilei opened this issue Jul 19, 2017 · 6 comments

Comments

@lilei
Copy link

lilei commented Jul 19, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Environment:

  • VSCode Version: 1.14.1
  • VsCodeVim Version: 0.9.0
  • OS: windows 10

What happened:

I collapse a code block from line 11 to line 20.
and on the line 11 ,I press J or arrow down
then the code block was expaned.
What did you expect to happen:
The code block keep collapsed and the cursor jump to line 21
How to reproduce it:

  1. Collapse a code block
  2. On the vim mode,press J on when the cursor was on the first line of the collapsed block.
@Chillee
Copy link
Member

Chillee commented Jul 20, 2017

Unluckily, I doubt this is something we can change. Folds are largely outside of our control, and even our current fix for moving across folds is unbelievably hackish.

@danawoodman
Copy link

According to microsoft/vscode#16858 they're saying it is the extension's issue. What would need to happen to get it to work?

@danawoodman
Copy link

Looks like this is fixed in #1552? Add "vim.foldfix": true to your settings.json fixes it for me

@Chillee
Copy link
Member

Chillee commented Aug 2, 2017

@danawoodman ah I thought he meant <shift-j>. That actually does work properly. If so, this is a duplicate.

I haven't closed the other relevant fold issue as our current solution is unbelievably hacky (and not in a good way).

@Chillee Chillee closed this as completed Aug 2, 2017
@transtone
Copy link

transtone commented Dec 20, 2017

DO NOT use vim.foldfix.

you need gj to replace j.

this tips is in the README file's Key remapping chapter.

@drahnieR
Copy link

DO NOT use vim.foldfix.

you need gj to replace j.

this tips is in the README file's Key remapping chapter.

using this mapping, commands like 100j becomes nightmare...
vim.foldfix works faster but still far away from the original setting.

@Chillee ideas on reopening this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants