Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SolutionIndicators logic #750

Closed
jcoupey opened this issue Jul 27, 2022 · 1 comment · Fixed by #755
Closed

Simplify SolutionIndicators logic #750

jcoupey opened this issue Jul 27, 2022 · 1 comment · Fixed by #755

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Jul 27, 2022

We use various heuristic tunings to reach to different initial solutions, then we apply our local search process on each and pick the best result in the end. The problem is that whenever two different tunings yield the same solution after the heuristic, we still run the local search on both instances. Thus we're potentially doing a significant amount of extra work for nothing.

In practice, heuristic + local search happen in a lambda that is called across multiple threads, so we'd have to keep this setup for heuristic only, then filter out identical heuristic solutions after joining all threads, then parallelize the local search using another lambda.

@jcoupey
Copy link
Collaborator Author

jcoupey commented Aug 4, 2022

Based on #755 (comment), this was not such a great idea. Yet, I'd like to keep some changes from #755 since computing SolutionIndicators values is now encapsulated directly in the struct ctor instead of doing it manually in client code.

@jcoupey jcoupey changed the title Filter out identical heuristic solutions Simplify SolutionIndicators logic Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant