You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks a lot for making this really efficient API wrapper around Vroom .
I have multiple routers setup for multiple regions and use cases, and want to be able to use the same vroom-docker / vroom-express instance, by sending in the host and port of the router in my api request.
I've gone through the source code (just 2 files, thank heavens!) and I'm thinking this is how we can do it:
check the request body for router's host and port
if present, then apply it in the options in the same place we're currently picking them from the config.yml, overriding the latter
remove them from the request body json so that they're no longer in that text that needs to be sent to vroom as input
I reckon something similar is already being done with "options" (g, c etc).
How does this sound?
The text was updated successfully, but these errors were encountered:
What you want to do is basically to override the default host/port config so this is indeed very similar to what is provided for other flags via the options object.
If you simply replicate the way it's done for other options, you could add support for -a and -p flags in options.a and options.p respectively, which would be enough. Happy to review a PR for such a change.
jcoupey
changed the title
Feature request: include router url in request body
Include router url in request body
Aug 22, 2023
Hi, thanks a lot for making this really efficient API wrapper around Vroom .
I have multiple routers setup for multiple regions and use cases, and want to be able to use the same vroom-docker / vroom-express instance, by sending in the host and port of the router in my api request.
I've gone through the source code (just 2 files, thank heavens!) and I'm thinking this is how we can do it:
I reckon something similar is already being done with "options" (g, c etc).
How does this sound?
The text was updated successfully, but these errors were encountered: