Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish latest image #72

Closed
nilsnolde opened this issue Nov 13, 2023 · 5 comments · Fixed by #77
Closed

Publish latest image #72

nilsnolde opened this issue Nov 13, 2023 · 5 comments · Fixed by #77

Comments

@nilsnolde
Copy link
Collaborator

I'd publish a latest image on a schedule, e.g. once a week, same as I do for Valhalla image. And the best that can be done considering this project is out-of-source. I'll add a clear description when exactly it's built (Sunday) and people will have to check upstream master commits against image build dates, for super bleeding edge.

@elkashefehab
Copy link

elkashefehab commented Nov 13, 2023

thank you, so when this version will be released?

@nilsnolde
Copy link
Collaborator Author

nilsnolde commented Nov 13, 2023

Feel free to do the changes yourself and PR, it's open source :) Otherwise it might take a bit.

@jcoupey
Copy link
Contributor

jcoupey commented Nov 13, 2023

I just pushed a release candidate for the next version, so building the v1.14.0-rc.1 tag with the usual workflow whenever possible would do the trick short-term.

On a longer-term consideration, I'm not sure publishing weekly images is really worth the trouble. The upstream dev happens in spikes with some busy periods. But most weeks in the year pass by without a merge to master...

@nilsnolde
Copy link
Collaborator Author

nilsnolde commented Nov 14, 2023

True. On the other hand it'd also remove the need to version this project at all and strictly stick to upstream, eg when updating the base image or so, when things are severely deprecated (eg we're still using node 12, that's ancient). I'm personally a big opponent of wasting CI hours, but we're talking < 10 hours on the whole year:)

Once I'd ever test docker artifact caching in CI, a single run would take not even 1 min if nothing changed upstream. But that'd be for next year:)

@nilsnolde
Copy link
Collaborator Author

v1.14.0-rc.1 will be published in 20 mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants