We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
currently we only test for a vroom-express failure it seems, meaning vroom is never actually called and issues like #61 can go unnoticed.
we definitely need to make that more robust and test for a 200 as well with the example2.json.
in fact, I just see that we actually do want to request for a 200, but curl doesn't fail unless called with --fail:
curl
--fail
vroom-docker/tests/test.sh
Lines 31 to 32 in df2a620
easy fix, I'll that real quick.
The text was updated successfully, but these errors were encountered:
18d85a9
No branches or pull requests
currently we only test for a vroom-express failure it seems, meaning vroom is never actually called and issues like #61 can go unnoticed.
we definitely need to make that more robust and test for a 200 as well with the example2.json.
in fact, I just see that we actually do want to request for a 200, but
curl
doesn't fail unless called with--fail
:vroom-docker/tests/test.sh
Lines 31 to 32 in df2a620
easy fix, I'll that real quick.
The text was updated successfully, but these errors were encountered: