Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden tests #62

Closed
nilsnolde opened this issue Aug 11, 2022 · 0 comments
Closed

harden tests #62

nilsnolde opened this issue Aug 11, 2022 · 0 comments

Comments

@nilsnolde
Copy link
Collaborator

currently we only test for a vroom-express failure it seems, meaning vroom is never actually called and issues like #61 can go unnoticed.

we definitely need to make that more robust and test for a 200 as well with the example2.json.

in fact, I just see that we actually do want to request for a 200, but curl doesn't fail unless called with --fail:

# tests that the service starts up alright
do_request > /dev/null

easy fix, I'll that real quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant