Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription in LinkCrawler#initUrl is unmanaged #3

Open
afollestad opened this issue Nov 26, 2018 · 0 comments
Open

Subscription in LinkCrawler#initUrl is unmanaged #3

afollestad opened this issue Nov 26, 2018 · 0 comments

Comments

@afollestad
Copy link
Contributor

getCode(url)
                .subscribeOn(Schedulers.io())
                .subscribe(...)

This subscription should be managed, otherwise you could end up with a leak if this operation takes longer than expected in real use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant