ソング：labファイルを書き出す機能を追加 #2383
ソング：labファイルを書き出す機能を追加 #2383
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
| // 「ファイル」メニュー | ||
| const fileSubMenuData = computed<MenuItemData[]>(() => [ | ||
| { | ||
| type: "button", | ||
| label: "音声を出力", | ||
| label: "音声書き出し", |
|
ちょっと実際に動かしてみて挙動だけチェックさせていただきました！ |
トラックの先頭を0秒としてlabファイル（音素タイミング）が書き出される形だと不便、ということでしょうか…？ |
|
あ、明らかに書き方を間違えました... トラックの最初のPhraseの始点が0秒だと不便、ですね。 |
|
なるほどです！ |
|
修正しました！ |
|
トラックの始点じゃなく、最初のpauが0票の基準になってそう？
|
|
マイナス時間のところを書き出さないようにしました！ |
|
必要な処理を消してました…修正しました！ |
| const characterInfo = getters.CHARACTER_INFO( | ||
| trackSinger.engineId, | ||
| trackSinger.styleId, | ||
| ); | ||
| if (characterInfo == undefined) { | ||
| // NOTE: characterInfoが存在しないというのは起こり得ないはずなので、存在しなかった場合はエラー | ||
| throw new Error( | ||
| "CharacterInfo corresponding to engineId and styleId does not exist.", | ||
| ); | ||
| } |
There was a problem hiding this comment.
元のコードはcharacterInfoが無かったときにcontinueするようになっていましたが、characterInfoが無いというのは起こり得ないと思うので、エラーをthrowするように変更しました。
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- src/components/Sing/ExportOverlay.vue: Evaluated as low risk
- src/components/Sing/SingEditor.vue: Evaluated as low risk
- src/mock/engineMock/synthesisMock.ts: Evaluated as low risk
- src/store/audio.ts: Evaluated as low risk
- src/components/Dialog/Dialog.ts: Evaluated as low risk
- src/store/type.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/store/singing.ts:2948
- The createArray function is not defined in the provided code, which could lead to runtime errors. Ensure that this function is defined or properly imported.
return createArray(
src/helpers/fileDataGenerator.ts:1
- [nitpick] The function writeUint32 should have a proper type annotation for the value parameter.
writeUint32 = (value: number) => {
src/helpers/fileDataGenerator.ts:1
- [nitpick] The function writeSample should have proper type annotations for the offset and value parameters.
writeSample = (offset: number, value: number) => {
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- src/components/Sing/ExportOverlay.vue: Evaluated as low risk
- src/components/Sing/SingEditor.vue: Evaluated as low risk
- src/mock/engineMock/synthesisMock.ts: Evaluated as low risk
- src/store/audio.ts: Evaluated as low risk
- src/components/Dialog/Dialog.ts: Evaluated as low risk
- src/store/type.ts: Evaluated as low risk
- src/sing/domain.ts: Evaluated as low risk
Comments suppressed due to low confidence (4)
src/store/utility.ts:518
- Add a test case to cover the generateLabelFileDataFromFramePhonemes function.
export async function generateLabelFileDataFromFramePhonemes(
src/store/singing.ts:3006
- The error message should include the actual frame rates being compared. Suggestion:
throw new Error(The frame rate between the phrase query (${phraseQuery.frameRate}) and the editor (${frameRate}) does not match.);
throw new Error("The frame rate between the phrase query and the editor does not match.");
src/helpers/fileDataGenerator.ts:66
- [nitpick] The parameter name 'obj' is ambiguous. It should be renamed to 'options' for clarity.
export async function generateTextFileData(obj: {
src/helpers/fileDataGenerator.ts:72
- Ensure that the encoding types are correctly handled and that there are no potential issues with the conversion.
const textBlob = {
|
こんな感じで28日の18時ごろに宣伝ポストさせていただこうと思います！ |
|
@Hiroshiba |
内容
labファイルを書き出す機能を追加します。
書き出し対象のトラックを指定できた方が良いと思いますが、ひとまず全てのトラックを対象として書き出す形で実装しています。
関連 Issue
その他