Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers for elements #75

Open
28 of 34 tasks
akaDuality opened this issue Aug 6, 2022 · 3 comments · Fixed by #142 or #154
Open
28 of 34 tasks

Containers for elements #75

akaDuality opened this issue Aug 6, 2022 · 3 comments · Fixed by #142 or #154
Assignees
Labels
design Improvements in user interface enhancement New feature or request epic Contains a lot of complicated subtasks

Comments

@akaDuality
Copy link
Collaborator

akaDuality commented Aug 6, 2022

VoiceOver can group elements to containers. We should support that.

Container has label and controls inside.

Designer

Navigator

Canvas

Settings

Refactoring

  • Simplify any AccessibilityView subclasses switch

Preview

Acceptance criteria:

How to create:

  • Group elements by containers in text area
  • Show group in document area
  • Give a name to area
  • Read area name by Preview
  • Also, this containers can be marked as modal
  • Select several elements in text area and group via context menu (or Command+G shortcut)

Discussion

@akaDuality akaDuality assigned akaDuality and unassigned akaDuality Aug 6, 2022
@akaDuality akaDuality added enhancement New feature or request question labels Aug 6, 2022
@akaDuality akaDuality added this to the Close beta milestone Aug 6, 2022
@akaDuality akaDuality changed the title Containers for element Containers for elements Aug 6, 2022
@akaDuality akaDuality modified the milestones: Close beta, Public beta Aug 6, 2022
@drucelweisse
Copy link
Collaborator

I'd like to try that one. What do you mean for "Show group in document area"? Is it rectangle that contains all controls in group?

@drucelweisse drucelweisse self-assigned this Aug 7, 2022
@akaDuality
Copy link
Collaborator Author

akaDuality commented Aug 7, 2022

Is it rectangle that contains all controls in group?

Yeah, like that. You can ask @bbsody for help

@akaDuality akaDuality added epic Contains a lot of complicated subtasks design Improvements in user interface and removed question labels Aug 9, 2022
@akaDuality
Copy link
Collaborator Author

Possible protocol:

import Document
protocol AccessibileView {
    var label: String { get set }
    var frame: CGRect { get set }
}

protocol AccessibilityContainer: AccessibilityView {
    var elements: [AccessibilityElement] { get set }
}

protocol AccessibilityElement: AccessibilityView {
    var isAccessibilityElement: Bool  { get set }
    var value: String  { get set }
    var hint: String  { get set }
    var trait: A11yTraits { get set }
}

@akaDuality akaDuality linked a pull request Nov 26, 2022 that will close this issue
7 tasks
Repository owner moved this from Design to Done in Development of VoiceOver Designer Nov 27, 2022
@akaDuality akaDuality reopened this Nov 27, 2022
@akaDuality akaDuality pinned this issue Dec 3, 2022
@akaDuality akaDuality linked a pull request Dec 10, 2022 that will close this issue
@akaDuality akaDuality reopened this Dec 16, 2022
@akaDuality akaDuality assigned akaDuality and unassigned drucelweisse Jan 3, 2023
@akaDuality akaDuality unpinned this issue Jan 29, 2023
@akaDuality akaDuality modified the milestones: Release, Next major version Feb 4, 2023
@akaDuality akaDuality pinned this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Improvements in user interface enhancement New feature or request epic Contains a lot of complicated subtasks
2 participants