Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message in console #14

Closed
MatthiasWanner opened this issue Jan 7, 2022 · 4 comments · Fixed by #18
Closed

Warning message in console #14

MatthiasWanner opened this issue Jan 7, 2022 · 4 comments · Fixed by #18
Labels

Comments

@MatthiasWanner
Copy link

Hey! I use your package frequently because it's really cool 😎 🙌.

I have a warning message in my console concerning the _metamask method using in the MetaMaskProvider (l.25)

const isUnlocked = await ethereum._metamask.isUnlocked();

Capture d’écran 2022-01-07 à 12 40 58

it is specified in the metamask doc that it is experimental:
https://docs.metamask.io/guide/ethereum-provider.html#experimental-api

@VGLoic
Copy link
Owner

VGLoic commented Jan 7, 2022

Hey! Thanks a lot for the kind words and the issue! I'm happy to see that this package is useful to people 😁

This is indeed a bit of a problem, I will dig a bit if I may find a stable replacement, I have not for now :(

PS: I'm trying to generalize a bit the approach of this package with other wallets in https://github.com/VGLoic/ethpp. Don't hesitate to take a look if you want :)

@MatthiasWanner
Copy link
Author

Thank you for the answer. I have been looking for an alternative to "isUnlocked" method but I think it requires the use of web3 or ethers.js. It's not a big deal because it works very well 😜.

@VGLoic
Copy link
Owner

VGLoic commented Feb 9, 2022

By taking a look at the code today, there is actually no need for this call to isUnlocked, I thought there was a locked status in order to justify this step but it does not exist 🤦 , and I don't think we should add it 🤔

So basically, I will just remove it 😅 and the warning should disappear at the same time 😁

@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants