Postgres support #100
Merged
Postgres support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrdoherty
approved these changes
Aug 9, 2024
| @@ -166,6 +166,11 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Since we're manually adding the postgres driver into tomcat, can you remove this?
| @@ -162,7 +162,7 @@ private void insertInstanceRow(InstanceInfo instanceInfo) throws WdkModelExcepti | |||
| Types.VARCHAR, // table name | |||
| Types.VARCHAR, // query name | |||
| Types.VARCHAR, // checksum | |||
| Types.CLOB // result message | |||
| Types.OTHER // result message | |||
There was a problem hiding this comment.
Curious about what led to this choice. Can we use platform functions to do this? Looks like we just have schema gen and writing methods, but I think that's because writing the value can be the same on both DBs? Maybe with a different column type in postgres?
| } | ||
| catch (SQLRunnerException e) { | ||
| throw WdkModelException.translateFrom(e); | ||
| } | ||
| } | ||
|
|
||
| private String getInsertUserRefSql() { |
There was a problem hiding this comment.
Will have to take your word for it on this one. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.