Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted reflections in Godot 4 (KHR_materials_unlit not working?) #57

Closed
grilikin opened this issue Mar 22, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@grilikin
Copy link

grilikin commented Mar 22, 2023

I might have put the wrong title, but the materials are sometimes glossy when they shouldn't.

I saw that while trying to transition from godot 3 to godot 4.

The problem was very much visible with the following vrm:
https://github.com/madjin/vrm-samples/blob/master/vroid/beta/Victoria_Rubin.vrm

Here's a screenshot from the (expected) godot 3 rendering:
image

And here's the same vrm with godot 4:
image

You can see that there's a huge reflexion on the face and hairs, when there shouldn't be.

I tried playing with the lighting, but even with almost nothing, I see everything black, and the bright white reflexion.

I'm not sure where the problem comes from, but I tried reimporting multiple times, and it just doesn't work.
Note that I did use the godot3 branch of godot-vrm for godot 3, and the main branch for godot4.

Also, it looks like it's specific to only some VRMs (the ones from VRoid Studio perhaps?)

Because one from Zoo Studio looks ok.
Godot 3:
image
Godot 4:
image

@grilikin grilikin changed the title KHR_materials_unlit not working Unwanted reflexions in Godot 4 (KHR_materials_unlit not working?) Mar 23, 2023
@grilikin
Copy link
Author

See #58
The line mentioned is causing this issue.

@fire fire changed the title Unwanted reflexions in Godot 4 (KHR_materials_unlit not working?) Unwanted reflections in Godot 4 (KHR_materials_unlit not working?) Apr 24, 2023
@fire fire added the bug Something isn't working label Jul 17, 2023
@lyuma
Copy link
Member

lyuma commented Aug 3, 2023

I have disabled Basis universal for now due to some bugs with it. Unfortunately that means we are embedding uncompressed textures.

We will need to work on the workflow for texture compression of VRM assets in the future.

@lyuma lyuma closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants