fix: babel transform-runtime bug #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfnelson
changed the title
xavxyz
reviewed
Jul 7, 2017
| @@ -8,8 +8,12 @@ | |||
| "url": "https://github.com/okgrow/merge-graphql-schemas.git" | |||
| }, | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": ">=4.8.3", | |||
| "npm": ">=4.0.0" | |||
There was a problem hiding this comment.
@xavcz Meteor is 4.8.3 , will drop it once meteor 1.6 is released.
| "scripts": { | ||
| "prepublish": ". ./scripts/prepublish.sh", | ||
| "prepare": ". ./scripts/prepublish.sh", |
There was a problem hiding this comment.
Is running npm publish triggering this command normally?
There was a problem hiding this comment.
@xavcz yes, npm publish & npm install will trigger the pre-publish in npm 4 land. In npm 5 pre-publish only runs on publish. See these two threads for more details npm/npm#16685 & npm/npm#10074 (comment)
|
Any eta on this PR getting into the production version of the module? |
Closed
|
Changes done in PR #71. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created to resolve a babel-runtime bug. For more details see here #68
Changes made:
prepublishtopreparein package.jsonbabel-preset-env& setting target to"node: "current"distfolder from .gitignore so it can be tested against withoutnpm link. Please see below in Testing.A PR we should keep our eyes on for specifying engines in
babel-preset-env. babel/babel-preset-env#114Testing:
You can test locally by running the below command in any project that is using the
merge-graphql-schemaspackage.npm install -S git://github.com/okgrow/merge-graphql-schemas#fix-babel-transform-runtime.Additionally the branch was tested via
npm linkagainst a node app runningnode 8.0.0/npm 5.0.3&meteor npm linkagainst a meteor app runningnode 4.8.3/npm 4.6.1.I would like others to further test this as I have seen some odd behaviour with
npm link. Remember torm -rf node_modules.