From ef193c5a9ba011f84f2bc1e0b3bddf859a8f580d Mon Sep 17 00:00:00 2001 From: Dhenain Ambroise Date: Tue, 3 Jan 2023 17:25:35 +0100 Subject: [PATCH 1/2] Update ubuntu version from 18 to 22 --- .eslintrc.yml | 1 - .github/workflows/auto-git-release.yml | 2 +- .github/workflows/auto-tag-on-release.yml | 2 +- .github/workflows/check-build.yml | 2 +- .github/workflows/run-integration-test.yml | 2 +- .github/workflows/update-codeclimate-coverage.yml | 6 +++--- README.md | 4 ++-- 7 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index cb8176f7..e4c8c496 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -45,7 +45,6 @@ rules: # See https://eslint.org/docs/rules quote-props: - warn - consistent-as-needed # Enforce consistency with quotes on props, either all must be quoted, or all unquoted for a given object - no-return-await: 0 # Useful before, but recent node.js enhancements make it useless on node 12+ (we use 10, but still, for consistency) - Read https://stackoverflow.com/questions/44806135/why-no-return-await-vs-const-x-await no-extra-boolean-cast: 0 # Don't enforce, let developer choose. Using "!!!" is sometimes useful (edge cases), and has a semantic value (dev intention) object-curly-newline: - warn diff --git a/.github/workflows/auto-git-release.yml b/.github/workflows/auto-git-release.yml index 34fec40b..e4b960eb 100644 --- a/.github/workflows/auto-git-release.yml +++ b/.github/workflows/auto-git-release.yml @@ -13,7 +13,7 @@ on: jobs: tag-and-release: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 with: diff --git a/.github/workflows/auto-tag-on-release.yml b/.github/workflows/auto-tag-on-release.yml index 640889e0..1733e94b 100644 --- a/.github/workflows/auto-tag-on-release.yml +++ b/.github/workflows/auto-tag-on-release.yml @@ -13,7 +13,7 @@ on: jobs: actions-tagger: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: Actions-R-Us/actions-tagger@v2.0.1 env: diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 74455a37..0c1012b6 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -14,7 +14,7 @@ on: jobs: run-build-test: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 - run: | diff --git a/.github/workflows/run-integration-test.yml b/.github/workflows/run-integration-test.yml index 164753b6..8fdeb8f5 100644 --- a/.github/workflows/run-integration-test.yml +++ b/.github/workflows/run-integration-test.yml @@ -15,7 +15,7 @@ on: jobs: run-integration-test: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 - run: yarn # Install all dependencies diff --git a/.github/workflows/update-codeclimate-coverage.yml b/.github/workflows/update-codeclimate-coverage.yml index e6534979..7f1d9129 100644 --- a/.github/workflows/update-codeclimate-coverage.yml +++ b/.github/workflows/update-codeclimate-coverage.yml @@ -15,8 +15,8 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn test:coverage` setup-environment: - name: Setup deployment environment (Ubuntu 18.04 - Node 12.x) - runs-on: ubuntu-18.04 + name: Setup deployment environment (Ubuntu 22.04 - Node 12.x) + runs-on: ubuntu-22.04 steps: - name: Installing node.js uses: actions/setup-node@v2.1.4 # Used to install node environment - XXX https://github.com/actions/setup-node @@ -24,7 +24,7 @@ jobs: node-version: '12.x' # Use the same node.js version as the one Vercel's uses (currently node12.x) run-tests-coverage: name: Run tests coverage and send report to Code Climate - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v1 - name: Installing dependencies diff --git a/README.md b/README.md index cd3458d4..659af72f 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ ```yaml jobs: wait-for-vercel-deployment: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - uses: UnlyEd/github-action-await-vercel@v1.2.14 id: await-vercel @@ -112,7 +112,7 @@ on: jobs: wait-for-vercel-deployment: - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - name: Retrieve deployment URL (example on how to set an ENV var) run: "echo VERCEL_DEPLOYMENT_URL=nextjs-bzyss249z.vercel.app >> $GITHUB_ENV" From 2597c4fda8db7cad11648135f45b839581d3a144 Mon Sep 17 00:00:00 2001 From: Dhenain Ambroise Date: Tue, 3 Jan 2023 17:26:47 +0100 Subject: [PATCH 2/2] Update node version from 12 to 16 + add .nvmrc --- .github/workflows/update-codeclimate-coverage.yml | 4 ++-- .nvmrc | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/update-codeclimate-coverage.yml b/.github/workflows/update-codeclimate-coverage.yml index 7f1d9129..b00b1767 100644 --- a/.github/workflows/update-codeclimate-coverage.yml +++ b/.github/workflows/update-codeclimate-coverage.yml @@ -15,13 +15,13 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn test:coverage` setup-environment: - name: Setup deployment environment (Ubuntu 22.04 - Node 12.x) + name: Setup deployment environment (Ubuntu 22.04 - Node 16.x) runs-on: ubuntu-22.04 steps: - name: Installing node.js uses: actions/setup-node@v2.1.4 # Used to install node environment - XXX https://github.com/actions/setup-node with: - node-version: '12.x' # Use the same node.js version as the one Vercel's uses (currently node12.x) + node-version: '16.x' # Use the same node.js version as the one Vercel's uses (currently node12.x) run-tests-coverage: name: Run tests coverage and send report to Code Climate runs-on: ubuntu-22.04 diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..6f7f377b --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +v16