Deprecated features - set-output and node.js 12

[GCyganek]

Running your action in my workflow I get these warnings:

According to the links attached to warning, both will throw errors starting in June. Are you planning to fix it?

[Vadorequest]

Thanks for bringing this to my attention - I wasn't aware.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2Show less
 
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

We will need to upgrade node to node 16 indeed. As for set-output, I'm not sure how that will affect this action, but we do rely on it so we should sort it out.

[Vadorequest]

#77 didn't fully fixed the issue, I guess we use actions that are using node12. We would need to update those, as well.

[Vadorequest]

This isn't a small feat, I thought upgrading node.js would be enough (at least for #1), but it isn't.

actions/checkout@v2 still use node12 (see https://github.com/actions/checkout/blob/v2.6.0/.github/workflows/check-dist.yml) so a major upgrade to v3 seems necessary, but major version bumps can lead to other issues 😕

[Vadorequest]

Blocking: #81, cannot update to node16, maintainer hasn't released a node16 version yet. See marvinpinto/actions#543

[Vadorequest]

Most of the warnings regarding node have been fixed. 2 dependencies couldn't be updated yet:

• Update PaulHatch/semantic-version (node16 support) #82
• Update marvinpinto/action-automatic-releases (node16 support) #81

I haven't looked into the other issue (set-output), which might be more serious and harder to migrate from.

[Vadorequest]

Example of migration (from another repo) :
https://github.com/marvinpinto/actions/pull/546/files

[Vadorequest]

@GCyganek Could you please confirm me whether you still get the warnings when using the latest version (v1.2.27)?

I don't get any warning in our latest build.

[GCyganek]

There is still warning for using node.js 12, the warning for set-outputs is gone

[Vadorequest]

It should be all good now.

Thank you for your quick feedback, it helped.

[GCyganek]

Yes, tested the latest version (v.1.2.38) and no warnings at all 👍 Good job!