feat: extend metrics with metadata #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
commented
Jul 10, 2024
| @@ -231,7 +231,7 @@ The initialize method takes the following arguments: | |||
|
|
|||
| ### instanceId | |||
|
|
|||
| As of version 5.0.0, `instanceId` is now automatically generated. | |||
There was a problem hiding this comment.
Scouting: Noticed this was wrong previously. We're already in v5, so next major is 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2389/extend-node-sdk-with-new-metrics
This extends the current metrics with metadata.
Tries being a bit fancy and grab other runtimes like
bunanddeno. E.g. if we run something in Bun that uses our SDK we can see it in the metrics payload:Similar to: Unleash/unleash-client-dotnet#231 and Unleash/unleash-client-ruby#177