Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and restore disabled tests #22

Open
joshpeterson opened this issue Dec 10, 2021 · 2 comments
Open

Investigate and restore disabled tests #22

joshpeterson opened this issue Dec 10, 2021 · 2 comments
Assignees
Labels
Tech Debt Known tech debt that we should address later

Comments

@joshpeterson
Copy link

We disabled some tests to test Linux CI to pass. See #21 for the disabled tests. We should understand why these tests fail on our CI and restore them.

@joshpeterson joshpeterson added the Tech Debt Known tech debt that we should address later label Dec 10, 2021
@joshpeterson
Copy link
Author

@brian-taylor-unity is working on getting the Linux tests to run via Docker now, as recommend. Once we have that working, we can run the tests in the same way that Microsoft's CI does, and hopefully they will pass.

@joshpeterson
Copy link
Author

We were able to use the Docker images to run the tests on Linux, but that did not actually correct the failing tests. We were able to re-enable some Linux tests that failed before though, and get down to just a small set of failing Linux tests that we need to remove asserts from: #35.

We'll need to continue to track dotnet#56633, where it looks like there is work going on to fix the asserts that we have removed temporarily. If that issue is handled upstream, then we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Known tech debt that we should address later
Projects
None yet
Development

No branches or pull requests

2 participants