From ade8881d24c797cf04f32edeb104f209d333f0bb Mon Sep 17 00:00:00 2001
From: Noel Stephens <noel.stephens@unity3d.com>
Date: Thu, 12 Dec 2024 03:41:35 -0600
Subject: [PATCH] fix: adding extended timeout to all universal rpc tests
 (#3170)

fix

Adding extended timeout to all universal rpc tests
---
 .../Tests/Runtime/UniversalRpcTests.cs        | 22 ++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs
index 99a775e021..b06bb97ea4 100644
--- a/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs
+++ b/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs
@@ -918,6 +918,7 @@ public void RethrowTargetInvocationException(Action action)
         }
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingNoOverride : UniversalRpcTestsBase
@@ -948,6 +949,7 @@ public void TestSendingNoOverride(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSenderClientId : UniversalRpcTestsBase
@@ -978,6 +980,7 @@ public void TestSenderClientId(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingNoOverrideWithParams : UniversalRpcTestsBase
@@ -1020,6 +1023,7 @@ public void TestSendingNoOverrideWithParams(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingNoOverrideWithParamsAndRpcParams : UniversalRpcTestsBase
@@ -1062,6 +1066,7 @@ public void TestSendingNoOverrideWithParamsAndRpcParams(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestRequireOwnership : UniversalRpcTestsBase
@@ -1098,6 +1103,7 @@ public void TestRequireOwnership(
         }
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestDisallowedOverride : UniversalRpcTestsBase
@@ -1133,6 +1139,7 @@ public void TestDisallowedOverride(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingWithTargetOverride : UniversalRpcTestsBase
@@ -1166,6 +1173,7 @@ public void TestSendingWithTargetOverride(
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingWithSingleOverride : UniversalRpcTestsBase
@@ -1213,6 +1221,7 @@ public IEnumerator TestSendingWithSingleOverride()
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingWithSingleNotOverride : UniversalRpcTestsBase
@@ -1261,7 +1270,7 @@ public IEnumerator TestSendingWithSingleNotOverride()
     }
 
     [Timeout(1200000)]
-    [TestFixture(HostOrServer.Host)]    
+    [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSendingWithGroupOverride : UniversalRpcTestsBase
     {
@@ -1288,7 +1297,6 @@ public enum AllocationType
 
         // Extending timeout since the added yield return causes this test to commonly timeout
         [Test]
-        [Ignore("Test Needs Refactor")]
         public void TestSendingWithGroupOverride(
             [Values] SendTo defaultSendTo,
             [ValueSource(nameof(RecipientGroups))] ulong[] recipient,
@@ -1339,7 +1347,7 @@ [Values] AllocationType allocationType
         }
     }
 
-    
+
     [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
@@ -1366,10 +1374,9 @@ public enum AllocationType
             List
         }
 
-        
+
         // Extending timeout since the added yield return causes this test to commonly timeout
         [Test]
-        [Ignore("Test Needs Refactor")]
         public void TestSendingWithGroupNotOverride(
             [Values] SendTo defaultSendTo,
             [ValueSource(nameof(RecipientGroups))] ulong[] recipient,
@@ -1420,6 +1427,7 @@ [Values] AllocationType allocationType
         }
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner : UniversalRpcTestsBase
@@ -1430,6 +1438,7 @@ public UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner(Hos
         }
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestDeferLocal : UniversalRpcTestsBase
@@ -1617,6 +1626,7 @@ public IEnumerator TestDeferLocalOverrideToFalse()
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestMutualRecursion : UniversalRpcTestsBase
@@ -1666,6 +1676,7 @@ public void TestMutualRecursion()
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
     internal class UniversalRpcTestSelfRecursion : UniversalRpcTestsBase
@@ -1705,6 +1716,7 @@ public void TestSelfRecursion()
 
     }
 
+    [Timeout(1200000)]
     [TestFixture(ObjType.Server)]
     [TestFixture(ObjType.Client)]
     internal class UniversalRpcTestRpcTargetUse : UniversalRpcTestsBase