Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure device is removed from running Zino state when a router is removed from polldevs.cf #142

Open
lunkwill42 opened this issue Jan 12, 2024 · 3 comments
Labels
discussion enhancement New feature or request

Comments

@lunkwill42
Copy link
Member

No description provided.

@lunkwill42 lunkwill42 added enhancement New feature or request discussion labels Jul 9, 2024
@lunkwill42
Copy link
Member Author

I think this may already be implemented, but we should check.

@johannaengland
Copy link
Contributor

Yes, this is already take care of when loading the pollfile:

for device in deleted_devices:
del state.polldevs[device]

@johannaengland
Copy link
Contributor

johannaengland commented Aug 1, 2024

Actually, now that I think about it further, we do remove the device from state.polldevs, but we still keep a lot of information in state.state, specifically state.state.devices and state.state.addresses and potentially state.state.flapping.

So a discussion is probably in order on how much information we want to keep about devices that have been removed from the pollfile.

@johannaengland johannaengland reopened this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants