Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research how SonarQube's scans can be augmented with linter reports from ruff. #10

Open
johannaengland opened this issue May 8, 2023 · 4 comments
Labels
post-zino2.0 These are features Zino1 does not have, but might be desired later

Comments

@johannaengland
Copy link
Contributor

johannaengland commented May 8, 2023

It might also be interesting at this point to research how SonarQube's scans can be augmented with linter reports from ruff (which this project uses).

I did pick up somewhere that SQ is supposed to be able to consolidate its own linting rules with reports from third party tools (PyLint was specifically mentioned, which is what NAV uses/used to use), and I would very much like to get this to work for all our projects at some point.

Originally posted by @lunkwill42 in #3 (comment)

@johannaengland
Copy link
Contributor Author

Relevant link:
https://community.sonarsource.com/t/support-ruff-linter-report-files/79714/11

@lunkwill42 lunkwill42 linked a pull request Jan 30, 2024 that will close this issue
@lunkwill42 lunkwill42 removed a link to a pull request Jan 30, 2024
@lunkwill42
Copy link
Member

We should maybe consider switching to https://github.com/oxsecurity/megalinter as well - it appears to be a vastly improved and popular hard-fork of the super-linter. It appears to support ruff out of the box.

@johannaengland
Copy link
Contributor Author

I had a look at it already and it seems very useful for our case. The only thing that I was uncertain about is if we can use it since it has the AGPL-3.0 license and Zino is under Apache 2.0. I am not well versed enough in licenses to know if that matters if we just use megalinter as a tool.

@lunkwill42
Copy link
Member

lunkwill42 commented Mar 22, 2024

The license terms of megalinter will not affect Zino, as no Zino code will link with megalinter code.

@johannaengland johannaengland added the post-zino2.0 These are features Zino1 does not have, but might be desired later label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-zino2.0 These are features Zino1 does not have, but might be desired later
Projects
None yet
Development

No branches or pull requests

2 participants