Stop logging proxied 5XX Graphite errors #3260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 11s ⏱️ Results for commit 20aa215. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3260 +/- ##
==========================================
+ Coverage 60.58% 60.64% +0.06%
==========================================
Files 606 606
Lines 43733 43735 +2
Branches 48 48
==========================================
+ Hits 26494 26522 +28
+ Misses 17227 17201 -26
Partials 12 12 ☔ View full report in Codecov by Sentry. |
This adds a bit of complicated regression testing of #3259, which causes Dango to send error e-mail to NAV site admins when the proxied response code from Graphite-web is in the 5XX range.
This adds what amounts to a dirty hack to the graphite-web proxy view (i.e. it reaches into Django internals) to prevent Django from doing a full error response log when proxying 5xx class errors from graphite-web. It does so by tricking `django.utils.log.log_response()` into thinking that the response has already been logged (since our view function has no other control over how its return values are logged by Django). The reason for the 5xx response codes are not bugs in our view code, and does not need to trigger site admin e-mails.
lunkwill42
force-pushed
the
bugfix/no-django-email-on-graphite-web-errors
branch
from
f847310 to
20aa215
Compare
|
johannaengland
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds what amounts to a dirty hack to the graphite-web proxy view (i.e. it reaches into Django internals) to prevent Django from doing a full error response log when proxying 5xx class errors from graphite-web. It does so by tricking
django.utils.log.log_response()into thinking that the response has already been logged (since our view function has no other control over how its return values are logged by Django).The reason for the 5xx response codes are not bugs in our view code, and does not need to trigger site admin e-mails.
Adds regression tests and fixes #3259