Render CSRF token info in form content

[podliashanyk]

For #3055

This is to match the crispy forms behaviour in NAV 1:1. Ref https://github.com/django-crispy-forms/django-crispy-forms/blob/baf94397a011b3f15a9899097234caa68b86a65e/crispy_forms/templates/uni_form/whole_uni_form.html#L2 where csrf_token is always included in POST-forms since in NAV we never set disable_csrf to True in code or context.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	992		0	11.42s
✅ PYTHON	ruff	987		0	0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 24s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit f0f0b1e.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (a7246a2) to head (f0f0b1e).
Report is 366 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         605      605           
  Lines       43823    43823           
  Branches       48       48           
=======================================
  Hits        26504    26504           
  Misses      17307    17307           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hmpf]

Needs a changelog because if we turn TEMPLATE_DEBUG on without already having the token in context there will be a lot of exceptions.

[podliashanyk]

Needs a changelog because if we turn TEMPLATE_DEBUG on without already having the token in context there will be a lot of exceptions.

Was on my way to add a changelog entry but then realised that this one is a pure refactor. We preserve the behaviour that crispy already provides. Or am I missing something @hmpf?

[hmpf]

Have you tried with crispy on and TEMPLATE_DEBUG on? If that doesn't lead to noise we're (hopefully) good.

[podliashanyk]

Have you tried with crispy on and TEMPLATE_DEBUG on? If that doesn't lead to noise we're (hopefully) good.

What do you mean by "with crispy on"?
Is adding TEMPLATE_DEBUG=True in python/nav/etc/nav.conf enough to turn it on?

[hmpf]

What do you mean by "with crispy on"?

Try a NAV prior to the uncrispyfying code.

Is adding TEMPLATE_DEBUG=True in python/nav/etc/nav.conf enough to turn it on?

Should be!

[podliashanyk]

What do you mean by "with crispy on"?

Try a NAV prior to the uncrispyfying code.

Is adding TEMPLATE_DEBUG=True in python/nav/etc/nav.conf enough to turn it on?

Should be!

Ok, have checked. No exceptions in the browser, or in docker containers. But I guess it doesn't hurt to add a (temporary) changelog fragment.

[hmpf]

Good changelog, means it will be easy to find where it has been set!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[stveit]

Seems good, tested before and after and POST data now includes a csrfmiddlewaretoken, same as crispyforms do