Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies that (still) depend on pkg_resources #2814

Open
hmpf opened this issue Feb 20, 2024 · 5 comments
Open

Dependencies that (still) depend on pkg_resources #2814

hmpf opened this issue Feb 20, 2024 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@hmpf
Copy link
Contributor

hmpf commented Feb 20, 2024

While with #2798 NAV itself no longer uses pkg_resources for anything, there are still warnings when running tests:

jnpr

.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
  /source/.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('jnpr')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

This library is a sub-dependency of something else.

sphinxcontrib-programoutput

.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
  /source/.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('sphinxcontrib')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

This library is explicitly declared in "requirements/base.txt". There has been no new versions of this since 2021 and it is still on setup.py. It is BSD-licensed so it should be possible to vendor the code.

zope

.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
  /source/.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('zope')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

This library is a sub-dependency of something else.

@hmpf hmpf added the dependencies Pull requests that update a dependency file label Feb 20, 2024
@lunkwill42
Copy link
Member

lunkwill42 commented Feb 26, 2024

jnpr

.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871
  /source/.tox/unit-py37-django32/lib/python3.7/site-packages/pkg_resources/__init__.py:2871: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('jnpr')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

jnpr is actually the main namespace of the junos-eznc package, which is a requirement of the JunOS driver of the NAPALM library. Maybe we should file a bug report with https://github.com/Juniper/py-junos-eznc ?

Usage is directly from this file: https://github.com/Juniper/py-junos-eznc/blob/master/lib/jnpr/__init__.py

@lunkwill42
Copy link
Member

This library is explicitly declared in "requirements/base.txt". There has been no new versions of this since 2021 and it is still on setup.py. It is BSD-licensed so it should be possible to vendor the code.

A quick search seems to reveal there may be several packages that provide this same functionality, so we might also look into migrating to something else.

@lunkwill42
Copy link
Member

This library is a sub-dependency of something else.

twisted has a dependency to the package zope-interface. We are currently attempting to upgrade our twisted dependency, which may or may not affect this.

@lunkwill42
Copy link
Member

Assigning @johannaengland for now, mostly to look at the sphinxcontrib-programoutput part of the issue

@johannaengland
Copy link
Contributor

twisted has a dependency to the package zope-interface. We are currently attempting to upgrade our twisted dependency, which may or may not affect this.

It does not, the current release of twisted still uses the same version of zope-interface as the version we currently use (22.8.0) uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants