You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
#2655 moved more of NAV's Python package definition into pyproject.toml, but script installation from the bin/ directory is still handled by setuptools in setup.py.
Describe the solution you'd like
Our goal is to remove setup.py in its entirety, so we need to define the installable scripts in pyproject.toml instead.
However, a scripts definition in pyproject.toml cannot be code based. All scripts need to be referenced explicitly, and rather than being pointers to just a script file, they need to be resolvable as a function in a Python module.
This installs a command my_package_cli which will run the run function in the my_package.console module.
This means that NAV's script files need to move out ot bin/ and somewhere into python/nav/. I suggest simply python/nav/bin/ for now.
I suppose all the existing scripts have main functions as their entrypoint.
Additionally, there are integration tests that enumerate all the scripts in the bin/ directory and test that they can be run without error. These tests will need to change, but perhaps they only need to find the scripts in a new directory.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
#2655 moved more of NAV's Python package definition into
pyproject.toml
, but script installation from thebin/
directory is still handled by setuptools insetup.py
.Describe the solution you'd like
Our goal is to remove
setup.py
in its entirety, so we need to define the installable scripts inpyproject.toml
instead.However, a scripts definition in
pyproject.toml
cannot be code based. All scripts need to be referenced explicitly, and rather than being pointers to just a script file, they need to be resolvable as a function in a Python module.Example:
This installs a command
my_package_cli
which will run therun
function in themy_package.console
module.This means that NAV's script files need to move out ot
bin/
and somewhere intopython/nav/
. I suggest simplypython/nav/bin/
for now.I suppose all the existing scripts have
main
functions as their entrypoint.Additionally, there are integration tests that enumerate all the scripts in the
bin/
directory and test that they can be run without error. These tests will need to change, but perhaps they only need to find the scripts in a new directory.The text was updated successfully, but these errors were encountered: