Cancel maintenance task when all its components have been deleted

[ingeborgoh]

Original description

NAV 5.1.1

Netbox is on maintenance. Netbox is deleted.The Maintenance-task still exists with State Active and
Components IP Device: ID 4430 (Component was deleted)

Expectation: The deleted netbox should also be deleted from the Components list of matching Active Maintenance Tasks.

If this is the last component, the whole Task should be Canceled.

Feature breakdown

After discussions in the NAV reference committee, we've agreed on an implementation that doesn't change history after-the-fact. This feature can be broken down to:

• Save a description of maintenance components for use when the referenced components have been deleted #3228
• Automatically cancel a maintenance task when all its components have been deleted #3229

[lunkwill42]

Expectation: The deleted netbox should also be deleted from the Components list of matching Active Maintenance Tasks.

I disagree with this expectation. I don't want to get back to a maintenance task and wonder why components I added to it are suddenly removed. I think it's better to list them as having been removed, as it is now.

If this is the last component, the whole Task should be Canceled.

This I can agree with. If all the components of a task have been removed from NAV, the task no longer serves a purpose, and it could be canceled.

There could be two ways of going about this. Either:

1. Add database triggers when modules, netboxes rooms or locations are deleted. These triggers will check any dependent maintenance tasks and close them if all components are deleted. However, maintaining a trigger like this could be tedious.

or

2. The maintengine is a cronjob (every 5 minutes) that is already responsible for switching task states and posting maintenanceState events for components as tasks change states. It is likely easier to have maintengine check the deletion status of components on all planned or active tasks, and cancel those tasks if all components are missing.

[lunkwill42]

Note from nav-ref: Verify whether maintenance logs errors when it encounters maintenance tasks where one or more devices have been deleted (read: lots of cron mail, potentially)

[lunkwill42]

I disagree with this expectation. I don't want to get back to a maintenance task and wonder why components I added to it are suddenly removed. I think it's better to list them as having been removed, as it is now.

Comment from UiO: Could this be made configurable in maintengine?

[lunkwill42]

Might be interesting to expand the component attribute to include a name or description of a component that may have been deleted later.